[feature] strict Promise configuration validation #298
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"instanceof": "Promise"
(configuration validation : strict "Promise" instanceof validation #258)What kind of change does this PR introduce?
feature/refactoring
Did you add tests for your changes?
Covered by existing tests.
If relevant, did you update the documentation?
n/a
Summary
Previously, validation for
Promise
configurations passed via"instanceof": "Function"
, withwebpack@4+
(ajv-keywords@3+
), we can do strict validation on"instanceof": "Promise"
.To accommodate this change we have to change the check to
anyOf
due toPromise
passing"type": "object"
.