Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from git:// to https:// #259

Merged
merged 1 commit into from
Feb 3, 2018
Merged

Change from git:// to https:// #259

merged 1 commit into from
Feb 3, 2018

Conversation

ematipico
Copy link
Contributor

@ematipico ematipico commented Feb 1, 2018

What kind of change does this PR introduce?
Fixes #182

Did you add tests for your changes?
No

If relevant, did you update the documentation?
No

Summary
This is just a quick fix where we change the protocol git:// to https:// to allow most of the proxies to be able to download the cli. A further fix is to ask to release a new version with our patch.

Does this PR introduce a breaking change?
No

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@evenstensberg
Copy link
Member

Reviewing later Emmanuel, thanks for the PR 👏👏👏

@tgandrews
Copy link

Another option is to use github:ev1stensberg/generator#Feature-getArgument. This works for me behind a corporate proxy as well.

@evenstensberg evenstensberg merged commit d9e4d96 into webpack:master Feb 3, 2018
@hrasoa
Copy link

hrasoa commented Feb 6, 2018

Hi, when is the next release including this commit ? Thanks

@evenstensberg
Copy link
Member

By the end of the month. Clone the repo if you can't wait :)

@hrasoa
Copy link

hrasoa commented Feb 6, 2018

Ok thank you, I will wait

@dburrows
Copy link

dburrows commented Mar 5, 2018

Just FYI, I still can't use 4.0 due to the github link (I work in a pretty locked down environment) so getting ev1stensberg/generator released with the change and including it as a normal npm module would be much appreciated

@ematipico ematipico deleted the ematipico-patch-yeoman branch March 5, 2018 17:45
@evenstensberg
Copy link
Member

evenstensberg commented Mar 6, 2018

@ematipico can you do try that out? Change the requires into the webpack-local-fork like I did at the prev commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot install webpack-cli using npm
6 participants