fix: memory leak for inline workers (#252)

webpack-contrib · Jul 10, 2020 · f729e34 · f729e34
1 parent f03498d
commit f729e34
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/workers/InlineWorker.js b/src/workers/InlineWorker.js
@@ -39,7 +39,12 @@ module.exports = function inlineWorker(content, url, workerType) {
         blob = new Blob([content]);
       }
 
-      return CreateWorker(URL.createObjectURL(blob), workerType);
+      var objectURL = URL.createObjectURL(blob);
+      var worker = CreateWorker(objectURL, workerType);
+
+      URL.revokeObjectURL(objectURL);
+
+      return worker;
     } catch (e) {
       return CreateWorker(
         'data:application/javascript,' + encodeURIComponent(content),

diff --git a/src/workers/index.js b/src/workers/index.js
@@ -20,7 +20,8 @@ const getWorker = (file, content, options) => {
     )}, ${fallbackWorkerPath}, ${options.workerType})`;
   }
 
-  let worker = 'Worker';
+  let worker;
+
   switch (options.workerType) {
     case 'SharedWorker':
       worker = 'SharedWorker';