Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stats option #537

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

niedzielski
Copy link

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Expose a stats option to make hot module replacement and other
informational messages optional. Only stat presets are supported but the
API can be expanded to an object later if useful.

Breaking Changes

Additional Info

Expose a stats option to make hot module replacement and other
informational messages optional. Only stat presets are supported but the
API can be expanded to an object later if useful.
@niedzielski
Copy link
Author

So far as I can tell, these errors are false positives due to preexisting security audit failures.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need, webpack has built-in logger we should migrate on it

@niedzielski
Copy link
Author

Thank you for the fast feedback, @evilebottnawi! I'm sorry but I didn't quite understand the feedback. Are you saying to use the Webpack logger API, to abandon this change, or something else? Thank you!

@alexander-akait
Copy link
Member

Yes webpack logger API

@niedzielski
Copy link
Author

niedzielski commented Jun 12, 2020

@evilebottnawi, done (I think).

Edit: I tried to mimic the webpack-dev-server implementation and options as the HMR client context is very similar.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use built-in webpack logger, not loglever

@alexander-akait
Copy link
Member

webpack-dev-server@4 migrate on built-in webpack logger

@niedzielski
Copy link
Author

@evilebottnawi, thank you. Is this a good example to base the approach on?

@alexander-akait
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants