Add schema validation: Input Objects must not contain non-nullable circular references#492
Merged
vladar merged 4 commits intowebonyx:masterfrom Jun 12, 2019
spawnia:circular-references
Merged
Add schema validation: Input Objects must not contain non-nullable circular references#492vladar merged 4 commits intowebonyx:masterfrom spawnia:circular-references
vladar merged 4 commits intowebonyx:masterfrom
spawnia:circular-references
Conversation
…rcular references Spec change: graphql/graphql-spec#445 Reference implementation: graphql/graphql-js#1359
This reverts commit e5528d1
Member
|
That's great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Input Objects are allowed to reference other Input Objects. A circular reference occurs
when an Input Object references itself either directly or through subordinated Input Objects.
Circular references are generally allowed, however they may not be defined as an
unbroken chain of Non-Null fields. Such Input Objects are invalid, because there
is no way to provide a legal value for them.
The following examples are allowed:
This is fine because a value for
selfmay simply be omitted from the arguments.This also works as
selfcan just contain an empty list.The following examples are invalid:
Spec change: graphql/graphql-spec#445
Reference implementation: graphql/graphql-js#1359
I think this might be added to a
0.13release, since the relevant spec change is just a clarification.