Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table of contents as dl? #18

Open
aarongustafson opened this issue May 4, 2017 · 0 comments
Open

Table of contents as dl? #18

aarongustafson opened this issue May 4, 2017 · 0 comments

Comments

@aarongustafson
Copy link

aarongustafson commented May 4, 2017

I’m wondering: Does it make sense to use dl, dt, dd in lieu of div & p? The semantics might be better and it might provide opportunities to turn it all into a tree menu in the future.

Also recommend Title Case for the labels.

<dl class="module module--secondary table-of-contents" role="navigation">
    <dt class="toc-section-title--active">Collectors</dt>
    <dd>
        <ul class="toc-subsection-title">
            <li>
                <a href="/docs/developer-guide/collectors/how-to-develop-a-collector.html" class="toc-subsection-title--active">
                    How to develop a collector
                </a>
            </li>
        </ul>
    </dd>
    <dt class="toc-section-title--active">Rules</dt>
    <dd>
        <ul class="toc-subsection-title">
            <li>
                <a href="/docs/developer-guide/rules/how-to-test-rules.html" class="toc-subsection-title">
                    How to test rules
                </a>
            </li>
        </ul>
    </dd>
    <dt class="toc-section-title--active">Events</dt>
    <dd>
        <ul class="toc-subsection-title">
            <li>
                <a href="/docs/developer-guide/events/list-of-events.html" class="toc-subsection-title">
                    List of events emitted by a collector
                </a>
            </li>
        </ul>
    </dl>
</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants