Skip to content

Rename Feature/Limit to DeviceFeature/DeviceLimit #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kainino0x
Copy link
Collaborator

@kainino0x kainino0x commented May 1, 2025

As was proposed in the meeting. I'm still not really convinced this is worthwhile, but it is a little clearer (especially in C where you don't get much type safety - you can freely assign a WGPUFeatureName value to a WGPUInstanceFeatureName variable).

We could also consider just removing the old names. The migration is probably not so hard that this is necessarily worth keeping around. I did add a macro to disable the aliases though.

Also removes WGPU_TRUE/WGPU_FALSE from extension headers. Accidentally added those, they aren't needed since extensions include webgpu.h.

Fixes #522

@kainino0x kainino0x force-pushed the feature-limit-rename branch from 2d2b7b4 to 2c02f97 Compare May 1, 2025 22:27
@kainino0x kainino0x force-pushed the feature-limit-rename branch 2 times, most recently from f8df990 to 523e0a5 Compare May 6, 2025 00:58
@kainino0x kainino0x force-pushed the feature-limit-rename branch from 44a953a to d3645c9 Compare May 6, 2025 01:07
@kainino0x kainino0x requested review from cwfitzgerald and lokokung May 6, 2025 01:12
@kainino0x kainino0x marked this pull request as ready for review May 6, 2025 01:12
@lokokung
Copy link
Collaborator

lokokung commented May 6, 2025

Tbh, I'm not convinced it's worth it to rename these either... Unless we feel strongly about it, I'm heavily leaning towards just leaving it as is. I think that given the InstanceFeatures have the explicit name in them it should be clear enough.

@kainino0x kainino0x mentioned this pull request May 14, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SPIRV and WGSL support detection
2 participants