Proposal: remove WGPUVertexStepMode_VertexBufferNotUsed, with 1:1 mapping to JS #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kainino0x
force-pushed
the
vertex-buffer-hole
branch
2 times, most recently
from
80144cd to
d641c44
Compare
kainino0x
force-pushed
the
vertex-buffer-hole
branch
from
f8b74b8 to
01002d9
Compare
kainino0x
changed the title
|
I think this is sound and reasonable and would like to merge it tentatively (with #432 still on the agenda to discuss). PTAL |
lokokung
approved these changes
Dec 2, 2024
copybara-service bot
pushed a commit
to google/dawn
that referenced
this pull request
Dec 18, 2024
Spec PR: webgpu-native/webgpu-headers#439 Bug: 383147017 Change-Id: Ice767dc0de53f85c69b77fd3ea0d6732c86da39d Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/219814 Commit-Queue: Fr <beaufort.francois@gmail.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Dec 20, 2024
Spec PR: webgpu-native/webgpu-headers#439 Bug: 383147017 Change-Id: Idffb2d98a0c4f64281b4800225acadb7e3df59a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6097797 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/main@{#1399127}
hubot
pushed a commit
to google/skia
that referenced
this pull request
Dec 24, 2024
Spec PR: webgpu-native/webgpu-headers#439 Bug: 383147017 Change-Id: I1a8e84c8900b3e2d29c36ddb1732b1d6c54aedde Reviewed-on: https://skia-review.googlesource.com/c/skia/+/931016 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
copybara-service bot
pushed a commit
to google/dawn
that referenced
this pull request
Jan 3, 2025
Spec PR: webgpu-native/webgpu-headers#439 Bug: 383147017 Change-Id: I3bde3b146c1de31e5ea39f76286e4967e7c2320c Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/216675 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com>
copybara-service bot
pushed a commit
to google/dawn
that referenced
this pull request
Jan 6, 2025
Spec PR: webgpu-native/webgpu-headers#439 Bug: 383147017 Change-Id: If8761986ce0e02b4d37785480f145bceb479e525 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/221154 Commit-Queue: Fr <beaufort.francois@gmail.com> Reviewed-by: Loko Kung <lokokung@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that there was actually no good way to paper over the difference between the C API we had proposed, and the current JS API.
This draft finds a compromise that does work: it distinguishes between
WGPUVertexStepMode_UndefinedandWGPUVertexStepMode_Vertexif.attributeCount == 0.In other words, the sentinel is
{.stepMode=Undefined, .attributeCount=0}instead of just{.stepMode=VertexBufferNotUsed}, or just{.attributeCount=0}.Notably, this is flexible to whatever JS does in gpuweb/gpuweb#4999
since it can still represent both
nulland{ stepMode: whatever, attributes: [] }.Fixes #432
(dawn bug https://crbug.com/383147017)