Update all sentinel values, reserve 0 #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kainino0x
force-pushed
the
sentinels
branch
2 times, most recently
from
63154c8 to
dba877e
Compare
|
@cwfitzgerald @rajveermalviya @Kangz see above about the things I did differently than what we discussed (no need to review fully but feel free). Let me know if you think any of those changes are not good. |
|
No notes here |
Kangz
reviewed
Oct 3, 2024
Kangz
approved these changes
Oct 3, 2024
copybara-service bot
pushed a commit
to google/dawn
that referenced
this pull request
Nov 18, 2024
webgpu-native/webgpu-headers#364 Bug: 377820810 Change-Id: I541c24a84e076750d2a7cd1b8b786d2095509103 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/214854 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org>
copybara-service bot
pushed a commit
to google/dawn
that referenced
this pull request
Nov 21, 2024
This CL renames current Undefined values to BindingNotUsed=0 (still the default) for the following four enums: - WGPUBufferBindingType - WGPUSamplerBindingType - WGPUTextureSampleType - WGPUStorageTextureAccess webgpu-native/webgpu-headers#364 Bug: 377820810 Change-Id: Id75bd9f05a78e8f08a319ef70050f45423f37e3d Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/215114 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
copybara-service bot
pushed a commit
to google/dawn
that referenced
this pull request
Nov 26, 2024
This reverts commit bcfc294. Reason for revert: Fails Dawn -> Chromium Roll for MLDrift Original change's description: > webgpu.h: Update BindingNotUsed enum values | Part 1 > > This CL renames current Undefined values to BindingNotUsed=0 (still the > default) for the following four enums: > > - WGPUBufferBindingType > - WGPUSamplerBindingType > - WGPUTextureSampleType > - WGPUStorageTextureAccess > > webgpu-native/webgpu-headers#364 > > Bug: 377820810 > Change-Id: Id75bd9f05a78e8f08a319ef70050f45423f37e3d > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/215114 > Commit-Queue: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Kai Ninomiya <kainino@chromium.org> # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 377820810 Change-Id: I763de67cfb1fa6328c5b5cb5ebb3161e067e5ed9 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/216774 Reviewed-by: Shrek Shao <shrekshao@google.com> Reviewed-by: Brandon Jones <bajones@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
copybara-service bot
pushed a commit
to google/dawn
that referenced
this pull request
Dec 5, 2024
This is a reland of commit bcfc294 Original change's description: > webgpu.h: Update BindingNotUsed enum values | Part 1 > > This CL renames current Undefined values to BindingNotUsed=0 (still the > default) for the following four enums: > > - WGPUBufferBindingType > - WGPUSamplerBindingType > - WGPUTextureSampleType > - WGPUStorageTextureAccess > > webgpu-native/webgpu-headers#364 > > Bug: 377820810 > Change-Id: Id75bd9f05a78e8f08a319ef70050f45423f37e3d > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/215114 > Commit-Queue: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Kai Ninomiya <kainino@chromium.org> Bug: 377820810 Change-Id: I095a88650a181d96fb6930d3eb606cb26c029147 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/217976 Auto-Submit: Loko Kung <lokokung@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Commit-Queue: Loko Kung <lokokung@google.com> Reviewed-by: Shrek Shao <shrekshao@google.com>
copybara-service bot
pushed a commit
to google/dawn
that referenced
this pull request
Jan 8, 2025
This CL adds Undefined for the following binding types and change the default value in binding layout for those: - WGPUBufferBindingType: Undefined -> Uniform - WGPUSamplerBindingType: Undefined -> Filtering - WGPUTextureSampleType: Undefined -> Float - WGPUStorageTextureAccess: Undefined -> WriteOnly Spec PR: webgpu-native/webgpu-headers#364 Bug: 377820810 Change-Id: Ic96a6d2cc1387b6ebe9cef9a9dd1aa2e6789529c Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/219915 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com>
14 tasks
kainino0x
added a commit
to kainino0x/webgpu-headers
that referenced
this pull request
Apr 25, 2025
We decided that we would not name this: webgpu-native#45 (comment) But I missed it in webgpu-native#364. Technically breaking, but since it didn't do anything, any references to it are going to be trivial (e.g. `case` statements). Issue: webgpu-native#45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be reviewed as separate commits.
BindingNotUsed/VertexBufferNotUsedenum valuesUndefineds that don't need to existUndefinedThis is a bit different from the thing we previously discussed and agreed on:
BindingNotUsed=VertexBufferNotUsed=0 withUndefined=1 so that zero-init will triggerNotUsed. See Some enums' sentinel 0 values are indistinguishable from "undefined" defaulting #242 (comment)WGPUTextureFormat_ColorTargetNotUsed, opting to continue usingWGPUTextureFormat_Undefinedfor this, because there's basically no chance thatWGPUColorTargetState.formatbecomes optional. (Even if it did become "dynamic state" or something, I think we would use a different sentinel value thanundefinedin the JS API so that it had to be named explicitly.)Fixes #234
Fixes #242
EDIT: also fixes #45
(done in Dawn except for the NotUsed changes: https://crbug.com/377820810)