Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for code generation #294

Open
kainino0x opened this issue May 21, 2024 · 1 comment
Open

Tracking issue for code generation #294

kainino0x opened this issue May 21, 2024 · 1 comment
Labels
non-breaking Does not require a breaking change (that would block V1.0)

Comments

@kainino0x
Copy link
Collaborator

For discussing assorted things related to the code generator (#259).

@kainino0x kainino0x added the non-breaking Does not require a breaking change (that would block V1.0) label May 21, 2024
@kainino0x
Copy link
Collaborator Author

May 9 meeting:

.yml differences with dawn.json (FYI)

  • AE: other day I decided to try to make dawn use the yaml file: convert from the yaml to our json file.
    • .yml doesn’t have default values
    • reserve 0-value of enums - either unnamed or “Undefined”. yml and dawn both are inconsistent right now
      • RM: Enum values are implicit for most enums in the yaml. There’s one or so that needed special numbering, so that is supported. WGPUSType_RenderPassDescriptorMaxDrawCount
      • Can put explicit numbers on all the enums if we need.
      • AE: Or be able to tell it to start at 1?
      • KN: Or do C-style numbering thing where you can set the first to 1, then it increments after that. But any solution is good
    • CreateRenderPipelineAsync with callback, assumes callback is called CreateRenderPipelineAsyncCallback, whereas dawn names them manually. Results in one difference: GetCompilationInfoCallback vs. CompilationInfoCallback
    • how to handle extra data - have an “extras: “ field in the .yml?
      • such as jsrepr (JS representation for Emscripten)
      • extras can be string->value map
      • and we can define extras in a separate yaml file
      • Should Go program be able to do the merging of multiple yamls into one json? Would require Go to be in the build process of Dawn so it can do the merging. Or just have each consumer do the merging it needs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-breaking Does not require a breaking change (that would block V1.0)
Projects
None yet
Development

No branches or pull requests

1 participant