Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WGPUTextureDataLayout name doesn't match WebIDL GPUImageDataLayout #286

Open
kainino0x opened this issue Apr 11, 2024 · 3 comments
Open
Labels
blocked on w3c Blocked on W3C gpuweb working group naming Bikeshedding names

Comments

@kainino0x
Copy link
Collaborator

kainino0x commented Apr 11, 2024

WGPUTextureDataLayout is called GPUImageDataLayout upstream (EDIT: and we have WGPUImageCopyBuffer and WGPUImageCopyTexture already in C). Probably they should match.

Note, we don't use the "image" language anywhere in the stable JS API though - only in dictionary names - so the upstream WebIDL can still be changed (I think). "Image" is kind of a confusing word; the naming deserves some more attention before it becomes part of a stable API.

@kainino0x kainino0x added the naming Bikeshedding names label Apr 11, 2024
@kainino0x kainino0x added the !discuss Needs discussion (at meeting or online) label Apr 11, 2024
@Kangz
Copy link
Collaborator

Kangz commented Apr 11, 2024

+1 for calling it WGPUImageDataLayout. The term image in the JS spec seems to refer to how pixels are laid out in linear memory for a single miplevel/aspect while the term texture is for the full breadth of non-linear memory things.

@kainino0x
Copy link
Collaborator Author

kainino0x commented Apr 11, 2024

Yes, we chose that naming in the JS spec intentionally to be different from "Texture" to refer to this concept. But I am still interested to see if we could come up with a clearer name than "Image", because that has overlap with Vulkan, new Image(), etc.

Apr 11 meeting:

  • (discussion)
  • CF: Two things
    • native should match the JS spec’s naming
    • we should poke the JS spec to reconsider this naming
  • Rename to match JS spec (tentatively WGPUImageDataLayout but also see what editors say on Monday)

@kainino0x kainino0x removed the !discuss Needs discussion (at meeting or online) label Apr 11, 2024
@kainino0x
Copy link
Collaborator Author

gpuweb/gpuweb#4573

@kainino0x kainino0x added the blocked on w3c Blocked on W3C gpuweb working group label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked on w3c Blocked on W3C gpuweb working group naming Bikeshedding names
Projects
None yet
Development

No branches or pull requests

2 participants