Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color spaces for presentation #200

Open
kainino0x opened this issue Jul 26, 2023 · 1 comment
Open

Color spaces for presentation #200

kainino0x opened this issue Jul 26, 2023 · 1 comment
Labels
has resolution Issue is resolved, just needs to be done presentation Presenting images to surfaces like windows and canvases

Comments

@kainino0x
Copy link
Collaborator

Split out from #197. See #197 (comment)
where we decided we should land other stuff eagerly before figuring this part out for WGPUSurfaceConfiguration.

@kainino0x kainino0x added the presentation Presenting images to surfaces like windows and canvases label Jul 26, 2023
@kainino0x
Copy link
Collaborator Author

kainino0x commented Jan 5, 2024

Jan 4 meeting:

  • Just add a color space enum and add it to WGPUSurfaceConfiguration. This is all WASM needs and it is probably enough for native too.
  • CF: Complicated part is exposing surface capabilities (which pairs of color space + format are valid)
    • But less urgent
    • There will be a way to query this (probably a list of pairs like wgpu), and validation in Configure()
  • KN: Initial native implementation can just only allow WGPUColorSpace_Undefined and not implement any other values (even WGPUColorSpace_sRGB)
    • CF: Why - is there a difference?
    • (discussion about whether/when compositors distinguish “sRGB” vs “display-native” on SDR displays, and some stuff about HDR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has resolution Issue is resolved, just needs to be done presentation Presenting images to surfaces like windows and canvases
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant