Skip to content

Commit 06b21fa

Browse files
Merge remote-tracking branch 'kesava/convert_to_yarn' into packages-setup
2 parents e1ca859 + df92ffb commit 06b21fa

10 files changed

+946
-449
lines changed

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,3 +45,5 @@ reports/
4545
!package-lock.json
4646
!tsconfig.json
4747
node_modules/
48+
.yarn/*
49+
!.yarn/releases

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
{
22
"name": "webex-widgets",
3-
"main": "index.js",
43
"repository": "git@github.com:webex/widgets.git",
54
"author": "devsupport@webex.com",
65
"license": "MIT",

packages/@webex/widgets/CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1+
## [1.27.5](https://github.com/webex/widgets/compare/v1.27.4...v1.27.5) (2024-10-29)
2+
3+
4+
### Bug Fixes
5+
6+
* **webex:** upgrading webex to new-version ([#235](https://github.com/webex/widgets/issues/235)) ([248aa87](https://github.com/webex/widgets/commit/248aa87c9c537d0a6ee41e2d85edc641c1cd4fc9))
7+
18
## [1.27.4](https://github.com/webex/widgets/compare/v1.27.3...v1.27.4) (2024-10-17)
29

310

packages/@webex/widgets/CONTRIBUTING.md

Lines changed: 6 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ We take testing very seriously, all code changes must include unit, integration
6666

6767
### Code Style
6868

69-
Code style is enforced by [linters](https://eslint.org). Use `npm run test:eslint` to verify that your code is beautiful, too!
69+
Code style is enforced by [linters](https://eslint.org). Use `yarn workspace @webex/widgets run test:eslint` to verify that your code is beautiful, too!
7070
We highly discourage disabling eslint rules.
7171
Unless there is an exceptional use case, we may request additional changes to your PR.
7272

@@ -171,26 +171,14 @@ Below you can find sample steps for linking a local `components` package to the
171171
```bash
172172
cd components
173173
npm install
174-
npx npm-install-peers (This is required to install peer dependencies if npm version is lower than 7)
175-
npm run build
176-
```
177-
178-
3. Change dependency location in `package.json` and install it
179-
```
180-
"@webex/components": "file:../components", // Or corresponding path to local clone
181-
npm install
182-
```
183-
184-
4. Install peer dependencies of `widgets` repository and the react dependency (this is required because`components` repository uses react)
185-
```
186-
npx npm-install-peers
187-
npm link ../components/node_modules/react
174+
yarn workspace @webex/widgets add @webex/components@link:PATH_TO_YOUR_COMPONENTS_REPO
175+
yarn workspace @webex/widgets run build
188176
```
189177

190-
5. Start up the widget sample
178+
3. Start up the widget sample
191179
```
192-
npm run start
180+
yarn workspace @webex/widgets run start
193181
```
194182

195183
Keep in mind that for every modification made in `components`/`sdk-component-adapter`, you need
196-
to run `npm run build` in the dependent repo.
184+
to run `yarn workspace @webex/widgets run build` in the dependent repo.

packages/@webex/widgets/docs/demo.bundle.c3b06fefec649e0cb4e2.js

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)