Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Webdriverio v7 screenshot issue/behaviour change webdriverio#9226 #10578

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

franck-jude
Copy link
Contributor

Proposed changes

//: # Fixes screenshot issue/behaviour change since webdriverio 7 #9226 ; Might probably also fix #7947 (takeElementScreenshot) ; fixes possible issues when emulating devices (takeScreenshot)

Types of changes

  • [ x ] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • [ x ] I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 13, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

It seems like Puppeteer has changed the API and it is very difficult to keep track of that and write tests for all these things. Great catch!

@christian-bromann
Copy link
Member

@franck-jude mind signing the CLA?

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jun 23, 2023
@christian-bromann christian-bromann merged commit 7b8319f into webdriverio:main Jun 23, 2023
@christian-bromann
Copy link
Member

Congratulations on your remarkable first contribution to WebdriverIO! This project thrives on the invaluable involvement of our community, and we are truly grateful for your contribution. We eagerly anticipate witnessing more of your exceptional work, so please don't hesitate to inform us if we can assist you in identifying intriguing areas where you can make further contributions. Join our lively Discord channel and reach out to us; we would be delighted to connect with you. Your efforts are deeply appreciated, and we extend our heartfelt gratitude to you. 🙏 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to get an exact screenshot of a specific element ?
2 participants