Skip to content

feat: provide proper dimensions based on emulated screens #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 17, 2025

Conversation

wswebcreation
Copy link
Member

@wswebcreation wswebcreation commented May 16, 2025

🐛 Bug-fixes

  • Visual Regression Changes in WDIO v9 #946: Visual Regression Changes in WDIO v9
    • Fixed screen size detection in emulated mode for filenames. Previously used incorrect browser window size.
    • Fixed screenshot behavior when enableLegacyScreenshotMethod: true, now correctly captures emulated screen instead of complete screen.
    • Fixed emulated device handling for Chrome and Edge browsers, now properly sets device metrics based on deviceMetrics or deviceName capabilities.

Committers: 1

Copy link

changeset-bot bot commented May 16, 2025

⚠️ No Changeset found

Latest commit: 72c8851

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wswebcreation
Copy link
Member Author

This should also fix #946

@wswebcreation wswebcreation marked this pull request as ready for review May 17, 2025 20:11
@wswebcreation wswebcreation merged commit 9363467 into main May 17, 2025
18 of 19 checks passed
@wswebcreation wswebcreation deleted the ws/add-emulated-mode-bm branch May 17, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant