fix waitForExpression

Author: christian-bromann

src/stringifyExtension.ts

@@ -252,7 +252,9 @@ export class StringifyExtension extends PuppeteerStringifyExtension {
         out: LineWriter,
         step: WaitForExpressionStep
     ): void {
-        out.appendLine(`await browser.executeAsync(async () => ${step.expression})`)
+        out.appendLine('await browser.waitUntil(() => (').startBlock()
+        out.appendLine(  `browser.execute(() => ${step.expression})`).endBlock()
+        out.appendLine(')')
     }
 
     getSelector(selectors: Selector[], flow: UserFlow): string | undefined {

test/stringifyExtension.test.ts

@@ -58,6 +58,22 @@ describe('StringifyExtension', () => {
     })
 
     it('should correctly exports change step', async () => {
+        const ext = new StringifyExtension()
+        const step = {
+            type: 'waitForExpression',
+            expression: 'document.querySelector(\'#someElem\').innerText === \' x 2\''
+        }
+        const flow = { title: 'change step', steps: [step] }
+        const writer = new InMemoryLineWriter('  ')
+        await ext.stringifyStep(writer, step as any, flow as any)
+        expect(writer.toString()).toBe(
+            'await browser.waitUntil(() => (\n' +
+            '  browser.execute(() => document.querySelector(\'#someElem\').innerText === \' x 2\')\n' +
+            ')\n'
+        )
+    })
+
+    it('supports waitForExpression', async () => {
         const ext = new StringifyExtension()
         const step = {
             type: 'change' as const,