refactor: extract create_parent_dirs into common utility

- Moved `create_storage_dir` logic to `src/common.c` as `create_parent_dirs`
  and declared it in `include/common.h` for reuse.
- Updated `wpc_lightdm_helper.c` and `config.c` to use the shared utility.
- Fixed unsafe string mutation by duplicating the input path in `create_parent_dirs`.
- Added `common.c` to build system (`Makefile` and `nob.c`).
- Corrected logic in `should_use_imagemagick7`: treat "0" as using IM6.
- Ensured `Monitor.wallpaper` is nulled before loading new GUI images.
- Fixed reversed ImageMagick pixel format conditional in `wallpaper.c`.

Author: webdevred

Makefile

@@ -33,7 +33,7 @@ endif
 ifeq ($(WPC_HELPER), 1)
     WPC_SRCS += $(SRC_DIR)/lightdm.c
     WPC_CFLAGS += -DWPC_ENABLE_HELPER
-    HELPER_SRCS := $(SRC_DIR)/wpc_lightdm_helper.c
+    HELPER_SRCS := $(SRC_DIR)/wpc_lightdm_helper.c $(SRC_DIR)/common.c
 endif
 
 WPC_OBJS := $(patsubst $(SRC_DIR)/%.c, $(BUILD_DIR)/%.o, $(WPC_SRCS))
@@ -78,7 +78,7 @@ endif
 iwyu:
 	@for file in $(WPC_SRCS) $(HELPER_SRCS); do \
 		echo "Running iwyu on $$file..."; \
-		include-what-you-use -Xiwyu --transitive_includes_only -std=c23 $(WPC_CFLAGS) $(WPC_LDFLAGS) -I$(INCLUDE_DIR) $$file; \
+		include-what-you-use -Xiwyu --transitive_includes_only -std=gnu11 $(WPC_CFLAGS) $(WPC_LDFLAGS) -I$(INCLUDE_DIR) $$file; \
 	done
 
 clean:

include/common.h

@@ -0,0 +1,5 @@
+#include <sys/stat.h>
+#include <sys/types.h>
+#include <unistd.h>
+
+extern int create_parent_dirs(const char *file_path, mode_t mode);

nob.c

@@ -31,6 +31,10 @@ void build_object(Nob_Cmd *cmd, LibFlagsDa *main_flags,
     }
 
     nob_cc_flags(cmd);
+    if (enable_dev_tooling)
+        nob_cmd_append(cmd, "-g", "-fsanitize=address",
+                       "-fno-omit-frame-pointer");
+
     nob_cmd_append(cmd, lib);
     uint nmain_flags = main_flags->count;
     uint ncommon_flags = common_flags->count;
@@ -151,7 +155,8 @@ Nob_File_Paths build_source_files(Nob_Cmd *cmd, const char *target,
                     continue;
                 }
             } else if (strcmp(target, "wpc_lightdm_helper") == 0) {
-                if (strcmp(object, "wpc_lightdm_helper.o") == 0) {
+                if (strcmp(object, "wpc_lightdm_helper.o") == 0 ||
+                    strcmp(object, "common.o") == 0) {
                     nob_da_append(&objects, object_place);
                 } else {
                     continue;
@@ -205,7 +210,7 @@ int build_target(Nob_Cmd *cmd, const char *target, Nob_File_Paths objects,
 void should_use_imagemagick7(Nob_Cmd *cmd) {
     char *imagemagick_version_env = getenv("WPC_IMAGEMAGICK_7");
     if (imagemagick_version_env != NULL) {
-        use_imagemagick7 = strcmp(imagemagick_version_env, "0") != 0;
+        use_imagemagick7 = strcmp(imagemagick_version_env, "0") == 0;
         goto log;
     }
 
@@ -227,11 +232,10 @@ void should_use_imagemagick7(Nob_Cmd *cmd) {
     free(buffer);
     cmd->count = 0;
 log:
-    char imagemagick_version = use_imagemagick7 ? '7' : '6';
     nob_log(NOB_INFO,
             "Chosen ImageMagick version: %c based on environment or system "
             "detection",
-            imagemagick_version);
+            use_imagemagick7 ? '7' : '6');
     return;
 }
 

src/common.c

@@ -0,0 +1,27 @@
+#include "common.h"
+#include <assert.h>
+#include <cjson/cJSON.h>
+#include <dirent.h>
+#include <errno.h>
+#include <fcntl.h>
+#include <glib.h>
+#include <libgen.h>
+#include <string.h>
+
+extern int create_parent_dirs(const char *file_path, mode_t mode) {
+    assert(file_path && *file_path);
+    char *path_copy = strdup(file_path);
+    if (!path_copy) return -1;
+    for (char *p = strchr(path_copy + 1, '/'); p; p = strchr(p + 1, '/')) {
+        *p = '\0';
+        if (mkdir(path_copy, mode) == -1) {
+            if (errno != EEXIST) {
+                *p = '/';
+                return -1;
+            }
+        }
+        *p = '/';
+    }
+    free(path_copy);
+    return 0;
+}

src/config.c

@@ -4,6 +4,7 @@
 #include <stdlib.h>
 #include <string.h>
 
+#include "common.h"
 #include "config.h"
 
 #define CONFIG_FILE ".config/wpc/settings.json"
@@ -344,7 +345,9 @@ extern Config *load_config() {
 }
 
 extern void dump_config(Config *config) {
-    FILE *file = fopen(get_config_file(), "w");
+    char *filename = get_config_file();
+    create_parent_dirs(filename, 0770);
+    FILE *file = fopen(filename, "w");
     if (file == NULL) {
         perror("Error opening configuration file");
         exit(1);

src/gui.c

@@ -137,6 +137,12 @@ static void show_images_src_dir(GtkApplication *app) {
     WallpaperArray *mon_wrap = g_object_get_data(G_OBJECT(app), "monitors");
     Monitor *monitors = (Monitor *)mon_wrap->data;
     gushort monitor_id;
+
+    for (monitor_id = 0; monitor_id < mon_wrap->amount_used; monitor_id++) {
+        Monitor *monitor = &monitors[monitor_id];
+        monitor->wallpaper = NULL;
+    }
+
     if (wallpapers) {
         gtk_flow_box_set_sort_func(GTK_FLOW_BOX(flowbox), NULL, NULL, NULL);
         gushort i;
@@ -366,6 +372,7 @@ static void storage_dir_chosen(GObject *source_object, GAsyncResult *res,
         g_warning("Error code: %d Error: %s", err->code, err->message);
         return;
     }
+
     new_src_dir = g_file_get_path(dir);
 
     update_source_directory(config, new_src_dir);

src/wallpaper.c

@@ -16,9 +16,9 @@ Atom wmDeleteWindow;
 XContext xid_context = 0;
 
 #ifdef WPC_IMAGEMAGICK_7
-const char *pixel_format = "RGBA";
-#else
 const char *pixel_format = "BGRA";
+#else
+const char *pixel_format = "RGBA";
 #endif
 
 static void set_bg_for_monitor(const gchar *wallpaper_path,

src/wpc_lightdm_helper.c

@@ -1,6 +1,7 @@
 #define _GNU_SOURCE
 #define _FILE_OFFSET_BITS 64
 
+#include "common.h"
 #include <assert.h>
 #include <cjson/cJSON.h>
 #include <dirent.h>
@@ -90,21 +91,6 @@ extern int lightdm_parse_config(char ***config_ptr, int *lines_ptr) {
     return 0;
 }
 
-static int create_storage_dir(const char *file_path, mode_t mode) {
-    assert(file_path && *file_path);
-    for (char *p = strchr(file_path + 1, '/'); p; p = strchr(p + 1, '/')) {
-        *p = '\0';
-        if (mkdir(file_path, mode) == -1) {
-            if (errno != EEXIST) {
-                *p = '/';
-                return -1;
-            }
-        }
-        *p = '/';
-    }
-    return 0;
-}
-
 static void copy_file(const char *src, const char *dst) {
     int fd_in, fd_out;
     off_t len, ret;
@@ -176,7 +162,7 @@ static int set_background(const char *scaled_wallpaper_path,
     if (dir) {
         closedir(dir);
     } else if (errno == ENOENT) {
-        if (create_storage_dir(dst_wallpaper_path, 0775) != 0) {
+        if (create_parent_dirs(dst_wallpaper_path, 0775) != 0) {
             fprintf(stderr, "Failed to create storage directory");
             return 1;
         }