QueryBuilder fix and feature #29
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed a bug in the each() method on the ObjectStore where only the first item can be accessed using the cursor approach. When using a cursor, the onsuccess function is called multiple times and cursor.continue() re-calls the method with the next value. Using $q.promise, the listener can only be called once with the first item. To continue to allow the caller to select with items to be added to the list, I added a $filter option when creating a QueryBuilder. This option allows the selection of a function to be called for each item in the cursor. It is called with one argument being the value (cursor.value), and if it returns truthy, the item is added to the result set which is eventually returns in the promise resolution. I don't know of another way to allow independent selection of values when using a promise and resolution.
In working further with your tool, I have found that the QueryBuilderDefaults are changed directly instead of being copied when make a new query. I have add a call to angular.extend({}, defaults) to correct this bug.