Skip to content
This repository was archived by the owner on Sep 7, 2022. It is now read-only.

Commit 567175d

Browse files
authored
Merge pull request #33 from stevemao/deps
change deps
2 parents f3dae22 + b50b5e9 commit 567175d

File tree

4 files changed

+10
-7
lines changed

4 files changed

+10
-7
lines changed

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,12 @@
3030
"react-addons-test-utils": "^0.14.3",
3131
"react-dom": "^0.14.3",
3232
"skatejs": "^0.14.3",
33-
"skatejs-build": "^4.2.3",
33+
"skatejs-build": "^7.2.0",
3434
"webcomponents.js": "0.7.22"
3535
},
3636
"peerDependencies": {
37-
"react": ">=0.14.0"
37+
"react": ">=0.14.0",
38+
"react-dom": ">=0.14.0"
3839
},
3940
"config": {
4041
"commitizen": {

src/index.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
import assign from 'object-assign';
22
import pascalCase from 'pascal-case';
3+
import React from 'react';
4+
import ReactDOM from 'react-dom';
35

46
const defaults = {
5-
React: window.React,
6-
ReactDOM: window.ReactDOM,
7+
React,
8+
ReactDOM,
79
};
810

911
function syncEvent(node, eventName, newEventHandler) {
@@ -31,7 +33,7 @@ export default function (CustomElement, opts) {
3133
const { React, ReactDOM } = opts;
3234

3335
if (!React || !ReactDOM) {
34-
throw new Error('React and ReactDOM must be globally available or passed via opts.');
36+
throw new Error('React and ReactDOM must be dependencies, globally on your `window` object or passed via opts.');
3537
}
3638

3739
class ReactComponent extends React.Component {

test/unit/errors.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import reactify from '../../src/index';
22

33
describe('prop-types', () => {
4-
const msg = 'React and ReactDOM must be globally available or passed via opts.';
4+
const msg = 'or passed via opts.';
55

66
it('no react', () => {
77
expect(() => reactify(document.registerElement('x-errors-1'), { React: null })).to.throw(msg);

test/unit/props.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ let x = 0;
66
function createComponentWithOpts(opts) {
77
return reactify(document.registerElement(`x-props-${x++}`, {
88
prototype: Object.create(HTMLElement.prototype, opts),
9-
}), { React, ReactDOM });
9+
}));
1010
}
1111
function createComponentWithProp(name, done) {
1212
return createComponentWithOpts({

0 commit comments

Comments
 (0)