Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to extend tx types #6493

Conversation

avkos
Copy link
Contributor

@avkos avkos commented Oct 10, 2023

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Fixes #6459

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@github-actions
Copy link

github-actions bot commented Oct 10, 2023

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 586 KB 586 KB 844 bytes 0.14%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Old size New size Diff Diff %
web3.min.js 568 KB 569 KB 844 bytes 0.15%
../lib/commonjs/index.d.ts 8.56 KB 8.56 KB 0 0.00%
../lib/commonjs/accounts.d.ts 3.67 KB 3.67 KB 0 0.00%
../lib/commonjs/types.d.ts 2.45 KB 2.45 KB 0 0.00%
../lib/commonjs/web3.d.ts 1.14 KB 1.14 KB 0 0.00%
../lib/commonjs/abi.d.ts 1000 bytes 1000 bytes 0 0.00%
../lib/commonjs/eth.exports.d.ts 280 bytes 280 bytes 0 0.00%
../lib/commonjs/providers.exports.d.ts 148 bytes 148 bytes 0 0.00%
../lib/commonjs/version.d.ts 60 bytes 60 bytes 0 0.00%

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #6493 (6eb3cd9) into 4.x (42502b6) will increase coverage by 0.00%.
Report is 1 commits behind head on 4.x.
The diff coverage is 90.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #6493   +/-   ##
=======================================
  Coverage   89.66%   89.67%           
=======================================
  Files         214      214           
  Lines        8206     8222   +16     
  Branches     2220     2223    +3     
=======================================
+ Hits         7358     7373   +15     
- Misses        848      849    +1     
Flag Coverage Δ
UnitTests 89.67% <90.90%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 10, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6eb3cd9
Status: ✅  Deploy successful!
Preview URL: https://e0fe95fd.web3-js-docs.pages.dev
Branch Preview URL: https://ok-6459-4-x--enable-plugins.web3-js-docs.pages.dev

View logs

@avkos avkos marked this pull request as ready for review October 12, 2023 14:57
} from '../common/index.js';
import { toUint8Array, uint8ArrayToBigInt, unpadUint8Array } from '../common/utils.js';
import { Common } from '../common/common.js';
import { Hardfork, Chain } from '../common/enums.js';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix dependency cycle

@@ -89,7 +89,7 @@ export async function getTransactionGasPricing<ReturnFormat extends DataFormat>(
throw new UnsupportedTransactionTypeError(transactionType);

// https://github.com/ethereum/EIPs/blob/master/EIPS/eip-2718.md#transactions
if (transactionType < '0x0' || transactionType > '0x7f')
if (Number(transactionType) < 0 || Number(transactionType) > 127)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix incorrect string comparing to numbers

@avkos avkos requested a review from jdevcs October 13, 2023 20:47
Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work.

maxFeePerGas: BigInt(5000000),
};
const sub = web3.eth.sendTransaction({ ...tx }, undefined, {
checkRevertBeforeSending: false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need checkRevertBeforeSending: false, please?
I think the user should not be forced to pass it. Except if there is no other way. And if so, this has to be be documented.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@avkos avkos merged commit 70d1957 into 4.x Oct 17, 2023
62 of 65 checks passed
@avkos avkos deleted the ok/6459-4.x]-Enable-plugins-to-register-builder-for-new-transaction-types branch October 17, 2023 01:06
@jdevcs jdevcs mentioned this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[4.x] Enable plugins to register builder for new transaction types
3 participants