web3-eth-contract validation test fail

[luu-alex]

Description

investigated #6461

const logs = await contractDeployed.getPastEvents('Transfer');
			const tokenId = (logs[0] as EventLog)?.returnValues?.tokenId as string;

in this line, logs can sometimes be undefined, creating this error.

Fix is to just use receipt and instead of getPastEvents
Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• I have selected the correct base branch.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation.
• My changes generate no new warnings.
• Any dependent changes have been merged and published in downstream modules.
• I ran npm run lint with success and extended the tests and types if necessary.
• I ran npm run test:unit with success.
• I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
• I ran npm run build and tested dist/web3.min.js in a browser.
• I have tested my code on the live network.
• I have checked the Deploy Preview and it looks correct.
• I have updated the CHANGELOG.md file in the root folder.
• I have linked Issue(s) with this PR in "Linked Issues" menu.

[github-actions]

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset	Old size	New size	Diff	Diff %
Total	585 KB	585 KB	0	0.00%

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	Old size	New size	Diff	Diff %
web3.min.js	567 KB	567 KB	0	0.00%
../lib/commonjs/index.d.ts	8.56 KB	8.56 KB	0	0.00%
../lib/commonjs/accounts.d.ts	3.67 KB	3.67 KB	0	0.00%
../lib/commonjs/types.d.ts	2.45 KB	2.45 KB	0	0.00%
../lib/commonjs/web3.d.ts	1.14 KB	1.14 KB	0	0.00%
../lib/commonjs/abi.d.ts	1000 bytes	1000 bytes	0	0.00%
../lib/commonjs/eth.exports.d.ts	280 bytes	280 bytes	0	0.00%
../lib/commonjs/providers.exports.d.ts	148 bytes	148 bytes	0	0.00%
../lib/commonjs/version.d.ts	60 bytes	60 bytes	0	0.00%

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Pages

Latest commit:	769d5d1
Status:	✅  Deploy successful!
Preview URL:	https://9aa8320e.web3-js-docs.pages.dev
Branch Preview URL:	https://6461.web3-js-docs.pages.dev

View logs

[codecov]

Codecov Report

Merging #6474 (769d5d1) into 4.x (9a5fd87) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##              4.x    #6474   +/-   ##
=======================================
  Coverage   89.65%   89.65%           
=======================================
  Files         213      213           
  Lines        8199     8199           
  Branches     2220     2220           
=======================================
  Hits         7351     7351           
  Misses        848      848           

Flag	Coverage Δ
UnitTests	89.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
web3	∅ <ø> (∅)
web3-core	∅ <ø> (∅)
web3-errors	∅ <ø> (∅)
web3-eth	∅ <ø> (∅)
web3-eth-abi	∅ <ø> (∅)
web3-eth-accounts	∅ <ø> (∅)
web3-eth-contract	∅ <ø> (∅)
web3-eth-ens	∅ <ø> (∅)
web3-eth-iban	∅ <ø> (∅)
web3-eth-personal	∅ <ø> (∅)
web3-net	∅ <ø> (∅)
web3-providers-http	∅ <ø> (∅)
web3-providers-ipc	∅ <ø> (∅)
web3-providers-ws	∅ <ø> (∅)
web3-rpc-methods	∅ <ø> (∅)
web3-utils	∅ <ø> (∅)
web3-validator	∅ <ø> (∅)

[jdevcs]

investigated #6461

const logs = await contractDeployed.getPastEvents('Transfer');
const tokenId = (logs[0] as EventLog)?.returnValues?.tokenId as string;
in this line, logs can sometimes be undefined, creating this error.

Fix is to just use receipt and instead of getPastEvents

Why logs were undefined? if tx is mined there should be logs available via getPastEvents, was there issue in tx waiting long in tests and not mined?

[Muhammad-Altabba]

investigated #6461
const logs = await contractDeployed.getPastEvents('Transfer');
const tokenId = (logs[0] as EventLog)?.returnValues?.tokenId as string;
in this line, logs can sometimes be undefined, creating this error.
Fix is to just use receipt and instead of getPastEvents

Why logs were undefined? if tx is mined there should be logs available via getPastEvents, was there issue in tx waiting long in tests and not mined?

I also think that we need to know why the logs were undefined sometime.

And I think either the proposed code will still fail in the same occasions where the old code fails. Or, if this would not be the case, then there is another issue that the users will face when using const logs = await contractDeployed.getPastEvents('Transfer'); outside the erc721 context.

Could you please @luu-alex investigate more on why and when the await contractDeployed.getPastEvents('Transfer') is returning undefined. And if you like, it could be helpful also to investigate this case with a code not related to erc721. Because, this is a generic functionality that could be used anywhere.

Many thanks,

[luu-alex]

sounds good @Muhammad-Altabba , this PR and i think this one as well was holding up release. I created an issue and will begin investigating. Thanks for the feedback

[luu-alex]

@jdevcs im not too sure, i will need to investigate getPastEvents next

[luu-alex]

Needs more investigation, it seems to be an issue with getpastevents returning undefined due to a change from validation