Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Conversation

@jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Aug 2, 2023

Fixed

Changed

@jdevcs jdevcs added Release 1.x 1.0 related issues labels Aug 2, 2023
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Pull Request Test Coverage Report for Build 5854516146

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 273 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+2.4%) to 75.125%

Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 2 64.29%
packages/web3-core-helpers/src/formatters.js 9 83.86%
packages/web3-core-helpers/src/errors.js 31 1.47%
packages/web3-utils/src/soliditySha3.js 34 3.43%
packages/web3-utils/src/index.js 40 40.3%
packages/web3-utils/src/utils.js 46 10.97%
packages/web3-eth-accounts/src/index.js 111 22.94%
Totals Coverage Status
Change from base Build 5730165452: 2.4%
Covered Lines: 3354
Relevant Lines: 4214

💛 - Coveralls

@jdevcs jdevcs marked this pull request as ready for review August 2, 2023 11:27
@jdevcs jdevcs changed the title Release/1.10.1 Release/1.10.1 RC Aug 2, 2023
Copy link
Contributor

@Muhammad-Altabba Muhammad-Altabba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
(However, I have one small suggestion)

@jdevcs jdevcs requested a review from Muhammad-Altabba August 7, 2023 08:20
@jdevcs jdevcs changed the title Release/1.10.1 RC Release/1.10.1 Aug 14, 2023
@jdevcs
Copy link
Contributor Author

jdevcs commented Aug 14, 2023

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

1.x 1.0 related issues Release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants