Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Bump typescript to 4.9.5 and ts-node to 10.9.1 #6238

Merged
merged 5 commits into from
Jun 28, 2023
Merged

Bump typescript to 4.9.5 and ts-node to 10.9.1 #6238

merged 5 commits into from
Jun 28, 2023

Conversation

@spacesailor24
Copy link
Contributor

@spacesailor24 spacesailor24 commented Jun 27, 2023

#5675 popped up again, and upgrading typescript to 4.9.5 seems to solve the issue

@spacesailor24 spacesailor24 added the 1.x 1.0 related issues label Jun 27, 2023
@spacesailor24 spacesailor24 self-assigned this Jun 27, 2023
spacesailor24
spacesailor24 commented Jun 27, 2023
View reviewed changes
@spacesailor24 spacesailor24 changed the title Bump typescript version to 4.9.5 Bump typescript to 4.9.5 and ts-node to 10.9.1 Jun 27, 2023
@github-actions
Copy link

github-actions bot commented Jun 28, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5396962488

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.139%
Totals Coverage Status
Change from base Build 4938779018: 0.0%
Covered Lines: 3353
Relevant Lines: 4212
💛 - Coveralls

@spacesailor24 spacesailor24 mentioned this pull request Jun 28, 2023
Closed
@spacesailor24 spacesailor24 force-pushed the wyatt/1.x/typescript-build-fix branch from 90ddc3d to a6f27ea Compare June 28, 2023 03:34
@spacesailor24 spacesailor24 marked this pull request as ready for review June 28, 2023 04:17
@luu-alex
Copy link
Contributor

luu-alex commented Jun 28, 2023

I believe mosiac tests have been failing for a while now

@spacesailor24
Copy link
Contributor Author

spacesailor24 commented Jun 28, 2023 •
edited
Loading

I believe mosiac tests have been failing for a while now

@luu-alex Yea, seems unrelated to these changes

#6242 to track it

@spacesailor24 spacesailor24 mentioned this pull request Jun 28, 2023
Merged
@spacesailor24 spacesailor24 merged commit 512aba7 into 1.x Jun 28, 2023
@spacesailor24 spacesailor24 deleted the wyatt/1.x/typescript-build-fix branch June 28, 2023 21:38
@jdevcs jdevcs mentioned this pull request Aug 2, 2023
Merged
This was referenced Sep 4, 2023
Open
Open
Open
Open
Open
@Mhmonicox Mhmonicox mentioned this pull request Sep 18, 2023
Open
This was referenced May 12, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced May 22, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 10, 2024
Open
Open
Open
@Mhmonicox Mhmonicox mentioned this pull request Oct 18, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jdevcs jdevcs Awaiting requested review from jdevcs jdevcs is a code owner

@Muhammad-Altabba Muhammad-Altabba Awaiting requested review from Muhammad-Altabba

2 more reviewers

@avkos avkos avkos approved these changes

@luu-alex luu-alex luu-alex approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@spacesailor24 spacesailor24

Labels

1.x 1.0 related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@spacesailor24 @luu-alex @avkos