This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Format transaction.type to hex. Add empty accessList is tx.type === '0x1'
#5979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4585263643Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
spacesailor24
requested review from
Muhammad-Altabba,
avkos,
jdevcs,
luu-alex and
nikoulai
as code owners
spacesailor24
changed the title
transaction.type to hex. Add empty accessList is `tx.type === '0x1'transaction.type to hex. Add empty accessList is tx.type === '0x1'
jdevcs
reviewed
Apr 3, 2023
jdevcs
reviewed
Apr 3, 2023
Contributor
jdevcs
left a comment
jdevcs
left a comment
There was a problem hiding this comment.
lgtm, except tiny refactoring.
Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com>
Contributor
Author
@jdevcs Merged, thank you |
luu-alex
approved these changes
Apr 3, 2023
avkos
previously requested changes
Apr 3, 2023
CHANGELOG.md
Outdated
| ### Changed | ||
|
|
||
| - `transaction.type` is now formatted to a hex string before being send to provider (#5979) | ||
| - When sending a transaction, if `transaction.type === '0x1' && transaction.accessList === []`, then `transaction.accessList` is set to `[]` (#5979) |
Contributor
There was a problem hiding this comment.
do you mean
transaction.type === '0x1' && transaction.accessList is undefined then transaction.accessList is set to []
?
spacesailor24
commented
Apr 3, 2023
Muhammad-Altabba
approved these changes
Apr 3, 2023
This was referenced Feb 23, 2024
Pull Request Test Coverage Report for Build 4600732589Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transaction.typeis now formatted to a hex string before being sent to providertransaction.type === '0x1' && transaction.accessList === 'undefined', thentransaction.accessListis set to[]Added test cases for Steps to Reproduce examples from here. With these changes everything is formatted as expected, however, we do not throw an error for
tx.typeexceededing bounds of0x0to0x7fcloses #4597