This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Update index.d.ts #5260
Merged
Update index.d.ts #5260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://web3-js-pr-5260.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cbaholnh8vld1f3p1ma0. |
this callback returns an array of event data Co-authored-by: Oleksii Kosynskyi <oleksii.kosynskyi@gmail.com> Co-authored-by: Nazar Hussain <nazarhussain@gmail.com> Co-authored-by: Nikos Iliakis <nikoulai@users.noreply.github.com>
nazarhussain
requested review from
avkos,
jdevcs,
luu-alex,
nikoulai and
spacesailor24
Pull Request Test Coverage Report for Build 2895682031
💛 - Coveralls |
jdevcs
suggested changes
Jul 18, 2022
jdevcs
suggested changes
Jul 18, 2022
Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com>
jdevcs
approved these changes
Jul 18, 2022
avkos
approved these changes
Jul 19, 2022
CHANGELOG.md
Outdated
| ### Security | ||
| - Updated `got` lib version and fixed other libs using npm audit fix (#5178) (#5254) | ||
|
|
||
| ## [Unreleased] |
Contributor
There was a problem hiding this comment.
As the previous version (1.7.5) was not released yet, is it possible to add those changes to 1.7.5-rc.0? Or would that violate the process?
Contributor
Author
There was a problem hiding this comment.
It was code freeze from our perspective, so we can't make any changes to it. The current workflow is to include the PR's in future release during the code freeze duration.
Contributor
Muhammad-Altabba
left a comment
Muhammad-Altabba
left a comment
There was a problem hiding this comment.
Looks good. However, I have a small question and tiny suggestions.
Thanks,
Co-authored-by: Muhammad Altabba <24407834+Muhammad-Altabba@users.noreply.github.com>
This was referenced Mar 3, 2023
This was referenced Mar 3, 2023
This was referenced Mar 7, 2023
This was referenced Mar 7, 2023
This was referenced Mar 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the CHANGELOG for the long awaited community PR #4955
Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildwith success.dist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.