Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Commit 7361a79

Browse files
refactor: pr review
1 parent 00e231e commit 7361a79

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

packages/web3-eth/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ Documentation:
267267
### Fixed
268268

269269
- Adds transaction property to be an empty list rather than undefined when no transactions are included in the block (#7151)
270-
w
270+
- Change method `getTransactionReceipt` to not be casted as `TransactionReceipt` to give proper return type (#7159)
271271

272272
## [Unreleased]
273273

packages/web3-eth/src/rpc_method_wrappers.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@ export async function getBlock<ReturnFormat extends DataFormat>(
296296
const result = {
297297
...res,
298298
transactions: res.transactions ?? [],
299-
};
299+
}
300300
return result;
301301
}
302302

@@ -530,11 +530,11 @@ export async function getTransactionReceipt<ReturnFormat extends DataFormat>(
530530
}
531531
return isNullish(response)
532532
? response
533-
: format(
533+
: (format(
534534
transactionReceiptSchema,
535535
response as unknown as TransactionReceipt,
536536
returnFormat ?? web3Context.defaultReturnFormat,
537-
);
537+
));
538538
}
539539

540540
/**
@@ -579,7 +579,7 @@ export function sendTransaction<
579579
| TransactionWithFromAndToLocalWalletIndex,
580580
returnFormat: ReturnFormat,
581581
options: SendTransactionOptions<ResolveType> = { checkRevertBeforeSending: true },
582-
transactionMiddleware?: TransactionMiddleware,
582+
transactionMiddleware?: TransactionMiddleware
583583
): Web3PromiEvent<ResolveType, SendTransactionEvents<ReturnFormat>> {
584584
const promiEvent = new Web3PromiEvent<ResolveType, SendTransactionEvents<ReturnFormat>>(
585585
(resolve, reject) => {
@@ -592,9 +592,9 @@ export function sendTransaction<
592592
returnFormat,
593593
});
594594

595-
let transaction = { ...transactionObj };
595+
let transaction = {...transactionObj};
596596

597-
if (!isNullish(transactionMiddleware)) {
597+
if(!isNullish(transactionMiddleware)){
598598
transaction = await transactionMiddleware.processTransaction(transaction);
599599
}
600600

packages/web3-eth/src/utils/decode_signed_transaction.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ export function decodeSignedTransaction<ReturnFormat extends DataFormat>(
3838
returnFormat: ReturnFormat,
3939
options: { fillInputAndData?: boolean; transactionSchema?: ValidationSchemaInput } = {
4040
fillInputAndData: false,
41-
transactionSchema: undefined,
4241
},
4342
): SignedTransactionInfoAPI {
4443
return {

0 commit comments

Comments
 (0)