Improve logging of connection errors (#5955)

clydedacruz · spacesailor24 · web-flow · commit 2097f8d74b6e · 2023-03-30T17:33:19.000-10:00
* Improve logging of connection errors Fixes. #5954 Existing code gobbles up the real error and only prints a generic message with the URL. This change utilizes the error object to give a better indication of what failed with the connection. * Updated CHANGELOG * Fix PR number in Changelog --------- Co-authored-by: Wyatt Barnes <me@wyatt.email>
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -662,3 +662,7 @@ Released with 1.0.0-beta.37 code base.
   - Updated dependencies (#5885)
 
 ## [Unreleased]
+
+### Fixed
+
+  - Improved the error propagation in `web3-providers-http` package to effectively propagate useful error infomation about failed HTTP connections (#5955)
diff --git a/packages/web3-providers-http/src/index.js b/packages/web3-providers-http/src/index.js
@@ -154,7 +154,7 @@ HttpProvider.prototype.send = function (payload, callback) {
             callback(errors.ConnectionTimeout(this.timeout));
         }
 
-        callback(errors.InvalidConnection(this.host));
+        callback(errors.InvalidConnection(this.host, error));
     }
 
     fetch(this.host, options)

Original file line number	Diff line number	Diff line change
`@@ -154,7 +154,7 @@ HttpProvider.prototype.send = function (payload, callback) {`
`154`	`154`	`callback(errors.ConnectionTimeout(this.timeout));`
`155`	`155`	`}`
`156`	`156`
`157`		`- callback(errors.InvalidConnection(this.host));`
	`157`	`+ callback(errors.InvalidConnection(this.host, error));`
`158`	`158`	`}`
`159`	`159`
`160`	`160`	`fetch(this.host, options)`