Skip to content

WebSocket: also test event origin #5958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2017
Merged

Conversation

annevk
Copy link
Member

@annevk annevk commented May 17, 2017

@ghost
Copy link

ghost commented May 17, 2017

View the complete job log.

Firefox (nightly)

Testing web-platform-tests at revision 17601c6
Using browser at version BuildID 20170516192431; SourceStamp b8e9b674033bcd1f3a4c59b9d0ee7619c1a17cc5
Starting 10 test iterations
All results were stable

All results

2 tests ran
/websockets/opening-handshake/003.html
Subtest Results Messages
OK
WebSockets: origin FAIL assert_equals: expected "ws://xn--n8j6ds53lwwkrqhv28a.web-platform.test:8888" but got "ws://天�����.web-platform.test:8888"
/websockets/opening-handshake/003.html?wss
Subtest Results Messages
OK
WebSockets: origin FAIL assert_unreached: Reached unreachable code

@ghost
Copy link

ghost commented May 17, 2017

View the complete job log.

Sauce (safari)

Testing web-platform-tests at revision 17601c6
Using browser at version 10.0
Starting 10 test iterations
All results were stable

All results

2 tests ran
/websockets/opening-handshake/003.html
Subtest Results Messages
OK
WebSockets: origin FAIL assert_unreached: Reached unreachable code
/websockets/opening-handshake/003.html?wss
Subtest Results Messages
OK
WebSockets: origin FAIL assert_unreached: Reached unreachable code

@ghost
Copy link

ghost commented May 17, 2017

View the complete job log.

Sauce (MicrosoftEdge)

Testing web-platform-tests at revision 17601c6
Using browser at version 14.14393
Starting 10 test iterations
All results were stable

All results

2 tests ran
/websockets/opening-handshake/003.html
Subtest Results Messages
OK
WebSockets: origin FAIL assert_unreached: Reached unreachable code
/websockets/opening-handshake/003.html?wss
Subtest Results Messages
OK
WebSockets: origin FAIL assert_unreached: Reached unreachable code

@ghost
Copy link

ghost commented May 17, 2017

View the complete job log.

Chrome (unstable)

Testing web-platform-tests at revision 17601c6
Using browser at version 60.0.3100.0 dev
Starting 10 test iterations
All results were stable

All results

2 tests ran
/websockets/opening-handshake/003.html
Subtest Results Messages
OK
WebSockets: origin FAIL assert_equals: expected true but got false
/websockets/opening-handshake/003.html?wss
Subtest Results Messages
OK
WebSockets: origin FAIL assert_unreached: Reached unreachable code

annevk added a commit to whatwg/html that referenced this pull request May 18, 2017
And rename “ASCII serialization of an origin” to “serialization of an
origin” though allow both to be used.

Not all implementations implemented the Unicode variant and the ones
that did, did so in a way that made it hard to use.

Tests:

* web-platform-tests/wpt#5939
* web-platform-tests/wpt#5940
* web-platform-tests/wpt#5941
* web-platform-tests/wpt#5944
* web-platform-tests/wpt#5946
* web-platform-tests/wpt#5955
* web-platform-tests/wpt#5957
* web-platform-tests/wpt#5958

URL Standard change: whatwg/url#311.

Service Worker specification follow-up issue: w3c/ServiceWorker#1142.

Fixes #2568.
@annevk annevk merged commit 3f89f64 into master May 18, 2017
@annevk annevk deleted the annevk/websocket-event-origin-idna branch May 18, 2017 04:29
alice pushed a commit to alice/html that referenced this pull request Jan 8, 2019
And rename “ASCII serialization of an origin” to “serialization of an
origin” though allow both to be used.

Not all implementations implemented the Unicode variant and the ones
that did, did so in a way that made it hard to use.

Tests:

* web-platform-tests/wpt#5939
* web-platform-tests/wpt#5940
* web-platform-tests/wpt#5941
* web-platform-tests/wpt#5944
* web-platform-tests/wpt#5946
* web-platform-tests/wpt#5955
* web-platform-tests/wpt#5957
* web-platform-tests/wpt#5958

URL Standard change: whatwg/url#311.

Service Worker specification follow-up issue: w3c/ServiceWorker#1142.

Fixes whatwg#2568.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants