Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UAX 14 not strictly required by css-text #46493

Open
frivoal opened this issue May 27, 2024 · 2 comments
Open

UAX 14 not strictly required by css-text #46493

frivoal opened this issue May 27, 2024 · 2 comments

Comments

@frivoal
Copy link
Contributor

frivoal commented May 27, 2024

I suspect the following two tests ought to be marked as "should" tests rather than the default must, as per https://web-platform-tests.org/writing-tests/css-metadata.html#requirement-flags, For the reasons covered in the Note at the end of https://drafts.csswg.org/css-text-4/#line-breaking

https://github.com/web-platform-tests/wpt/blob/master/css/css-text/line-breaking/line-breaking-028.html
https://github.com/web-platform-tests/wpt/blob/master/css/css-text/line-breaking/line-breaking-029.html

cc: @makotokato, @jfkthame (as authors/reviewers)

@jfkthame
Copy link
Contributor

I haven't tried to check extensively, but I suspect there are probably quite a few tests where this is the case -- they assume line-breaking behavior that is not strictly required by the spec, but in practice is what everyone expects. Unless there's an implementation that is actually wanting to deviate here, without being called out as non-compliant, I'm not sure there's much reason to soften the tests to use "should". What would the practical results of this be -- how do "should" tests (whether passing or failing) show up on wpt.fyi and other forms of reporting?

@frivoal
Copy link
Contributor Author

frivoal commented May 28, 2024

I don't believe wpt currently distinguishes. The old csswg test system did distinguish: when reporting results, it would separate "must" tests from "should" ones, which is useful when trying to progress a spec, as must failures are a sign that either implementations or the spec need fixing, while should failures can be allowed to persist. I hope that wpt will eventually gain this ability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants