Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*/callback-cross-realm-report-exception.html are flaky #44176

Open
wangxianzhu opened this issue Jan 24, 2024 · 3 comments
Open

*/callback-cross-realm-report-exception.html are flaky #44176

wangxianzhu opened this issue Jan 24, 2024 · 3 comments

Comments

@wangxianzhu
Copy link
Contributor

@shvaikalesh

The tests wait 25ms before checking the result. The time may not be enough when the test runner is slow (e.g. with a debug build or there are many parallel tests running).

@gsnedders
Copy link
Member

The time may not be enough when the test runner is slow (e.g. with a debug build or there are many parallel tests running).

Certainly with debug, and maybe even with parallel test execution, I'd hope you were passing a timeout multipler? That said, even with a 3x multiplier 25ms is only 75ms, which still isn't that long for something that needs to wait for the event loop to spin for a debug build.

@WeizhongX
Copy link
Contributor

Can we change this to 1 second?

@wangxianzhu
Copy link
Contributor Author

I think 1 second is worth trying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants