-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STP downloads are failing #34752
Comments
That's not a recent change. I suspect the actual change here that's broken things is the "Requires macOS 13 beta 3 or later." (notably with the number of the beta), though clearly something else has gone wrong for this to break the macOS 12 case too. |
For future testing usage:
I'm out all of next week, and don't really have enough internet connection right now, but this should just be changing the |
I investigated the issue. The regex capturing Safari Technology Preview was failing to match both Mac OS 12 and Mac OS 13 because the html was as follows: I changed the Now it is: |
Are you sure that the correction does indeed fix the problem? I just rerun the Azure Pipelines checks on a commit in PR34705 and I got the same error, same description. Details: Starting: Install Safari Technology PreviewTask : Command line
|
@TalbotG Thanks for that stack trace. The ValueError Exception occurs at line 1524. At line 1524 of my commit, this is the code: Lines 1523 to 1526 in f96f182
At line 1524 of the previous commit, you will find the ValueError exception Lines 1523 to 1525 in 3fc0804
|
Runs of STP are also back in https://wpt.fyi/runs, so let's call this fixed! Thanks @jcscottiii! |
STP downloads have begun failing. https://github.com/web-platform-tests/wpt/runs/7245617686 is a recent example with this log:
The error comes from here:
wpt/tools/wpt/browser.py
Lines 1516 to 1521 in 36fc6e2
Right now https://developer.apple.com/safari/resources/ says "Requires macOS 12.3 or later" so the problem is that we're matching the version exactly and don't consider this STP for "12.3 or later" a match for macOS 12.4.
The text was updated successfully, but these errors were encountered: