-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for shutdown crashtests? #34256
Comments
If it's really about navigation, we could consider forcing a load to e.g. "about:blank" after the crashtest has loaded and if that causes a crash mark the test as failing. That has a performance cost of course. Alternatively if we only want this for some tests, we could in principle have some metadata to indicate that the test requires an additional step post-load. Or I suppose we could finish the work to enable testdriver in crash tests and have some way for the test itself to trigger a navigation. |
That also sounds good. Bfcache should be suppressed in that case. (Disabling Bfcache makes sense if it's only for crashtest, but if we want to cover shutdown crash from non-crashtests then we can't disable it) |
Which option sounds good? :) The option where we unconditionally force a load at some performance cost, or the option where we give tests some way to opt in to an extra navigation as part of the test? |
Sorry for the late response. The second option definitely sounds less obtrusive, and could be even great if there was a CLI option to force that on all tests. |
Some tests can run well while the page is active but then crash while the page is being unloaded. Such crashing tests are marked as PASS by WPT even if there was a crash, since WPT does not restart the process for each test.
How about marking such tests as shutdown crashtests and shut the process down for those?
cc @jgraham, see also https://bugzilla.mozilla.org/show_bug.cgi?id=1766711.
The text was updated successfully, but these errors were encountered: