Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test results for hyphen wrapping in loose line-breaking are incorrect #31021

Open
r12a opened this issue Sep 29, 2021 · 5 comments
Open

Test results for hyphen wrapping in loose line-breaking are incorrect #31021

r12a opened this issue Sep 29, 2021 · 5 comments

Comments

@r12a
Copy link
Contributor

r12a commented Sep 29, 2021

https://wpt.fyi/results/css/css-text/line-break/line-break-loose-hyphens-001.html?label=experimental&label=master&aligned shows all browsers failing the test at https://github.com/web-platform-tests/wpt/blob/e3eb24eb27/css/css-text/line-break/line-break-loose-hyphens-001.html

however, that test passes if you actually look at the result of the test, see http://wpt.live/css/css-text/line-break/line-break-loose-hyphens-001.html

that the test passes is also supported by the i18n-test suite equivalent of that test. See https://www.w3.org/International/i18n-tests/run?base=css-text/line-break-property&batch=line-breaks-jazh&test=ja/css-text-line-break-ja-hyphens-loose.html

@frivoal i believe these tests are yours.

cc @himorin, since this affects a jlreq gap you recently submitted.

@xfq
Copy link
Contributor

xfq commented Sep 30, 2021

I just tested it. The results were different under different browsers:


Chrome 94:

chrome


Firefox 92.0.1:

firefox


Safari 15.0:
safari

@xfq
Copy link
Contributor

xfq commented Sep 30, 2021

I suspect that we need to change lang to ja.

@himorin
Copy link
Contributor

himorin commented Sep 30, 2021

I also confirm test and reference shows the same output on Firefox 92.0.1 Windows, w/o changing language parameter (lang=en is coded in both html files).

@r12a
Copy link
Contributor Author

r12a commented Sep 30, 2021

@xfq you got different results for different browsers for the WPT tests (i suspect that this may be because the default language for ideographic content varies across browsers).

But did you also check the i18n test suite tests. I checked those for Japanese and found that Firefox, Chrome, and Safari all pass the loose hyphens test. https://www.w3.org/International/i18n-tests/results/line-breaks-jazh#ja_loose

@xfq
Copy link
Contributor

xfq commented Oct 8, 2021

I just checked the i18n test suite tests and found that Firefox, Chrome, and Safari all pass the Japanese loose hyphens test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants