Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

false positives on shaping-arabic-diacritics-001 #24054

Open
frivoal opened this issue Jun 9, 2020 · 0 comments
Open

false positives on shaping-arabic-diacritics-001 #24054

frivoal opened this issue Jun 9, 2020 · 0 comments

Comments

@frivoal
Copy link
Contributor

frivoal commented Jun 9, 2020

css/css-text/shaping/shaping-arabic-diacritics-001.html passes as a reftest even in browsers that do not comform to the test's expectation.

Firefox nightly 79 (2020-06-08) passes correctly, as per the description.
But Firefox stable 77.0.1, Safari and Chrome all pass, even though the rendering doesn't match the description.

I suspect that might be meant to capture some of that, but it too passes in safari even though the rendering on -001 is wrong.

Not entirely sure how to tweak those tests, but tests passing when the condition isn't fulfilled isn't great.

@jfkthame I think these tests are from you, can you have a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant