Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OffscreenCanvas size.attributes.parse.empty test is not valid #19181

Open
Cwiiis opened this issue Sep 20, 2019 · 2 comments
Open

OffscreenCanvas size.attributes.parse.empty test is not valid #19181

Cwiiis opened this issue Sep 20, 2019 · 2 comments

Comments

@Cwiiis
Copy link
Contributor

Cwiiis commented Sep 20, 2019

This test tests that setting width or height to an empty string has no effect, but I don't believe this is a valid reading of the spec. The width and height properties are unsigned longs - An empty string is equivalent to +0 according to the spec https://tc39.es/ecma262/#sec-tonumber and the OffscreenCanvas spec makes no mention (that I see) of 0 being an invalid value for width or height. As far as I can tell, a correct implementation of OffscreenCanvas would fail this test.

@zcorpan
Copy link
Member

zcorpan commented Oct 14, 2019

The test is offscreen-canvas/the-offscreen-canvas/size.attributes.parse.empty.html?

cc @xidachen

@Cwiiis
Copy link
Contributor Author

Cwiiis commented Oct 15, 2019

The test is offscreen-canvas/the-offscreen-canvas/size.attributes.parse.empty.html?

That's correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants