Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OffscreenCanvas size.attributes tests don't take into account [EnforceRange] #19180

Open
Cwiiis opened this issue Sep 20, 2019 · 1 comment
Open

Comments

@Cwiiis
Copy link
Contributor

Cwiiis commented Sep 20, 2019

The width and height attributes of an OffscreenCanvas are declared with [EnforceRange] in the spec: https://html.spec.whatwg.org/multipage/canvas.html#offscreencanvas

This means that setting them to values outside of the range of an unsigned long should throw a TypeError - at least the test offscreen-canvas/the-offscreen-canvas/size.attributes.parse.minus.html assumes that you can just set a value that's out of range and expect no exception to occur, so this test will fail for correct implementations of OffscreenCanvas. I believe other size.attributes tests in the same directory may also be affected.

@zcorpan
Copy link
Member

zcorpan commented Oct 14, 2019

cc @xidachen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants