Skip to content

Commit daccc4b

Browse files
mfreed7chromium-wpt-export-bot
mfreed7
authored and
chromium-wpt-export-bot
committed
Add support for the shadow root clonable flag
This landed in the these two spec PRs: whatwg/dom#892 whatwg/dom#1237 and was discussed here: whatwg/dom#1137 whatwg/dom#1236 This CL adds support for clonable, behind a new ShadowRootClonable flag. There was already a very basic test, but I added a few more cases. This should be fairly web compatible, but there is a risk since with this feature enabled, declarative shadow roots in the main document (as opposed to in a <template> element) will now be cloned. I will launch this feature carefully. Safari has already shipped, and Gecko has implemented this and plans to ship soon. Chromestatus: https://chromestatus.com/feature/5161435196030976 I2P: https://groups.google.com/a/chromium.org/g/blink-dev/c/nZhPt0ePCAA Fixed: 1510466 Change-Id: Ie25b72f369ca0542555f91010b0f22d295403728
1 parent edec5cd commit daccc4b

File tree

2 files changed

+49
-10
lines changed

2 files changed

+49
-10
lines changed

‎shadow-dom/declarative/clonable.window.js‎

Lines changed: 0 additions & 10 deletions
This file was deleted.

‎shadow-dom/shadow-root-clonable.html‎

Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
<!DOCTYPE html>
2+
<title>Shadow root clonable flag</title>
3+
<link rel='author' href='mailto:krosylight@mozilla.com'>
4+
<link rel='author' href='mailto:masonf@chromium.org'>
5+
<link rel='help' href='https://dom.spec.whatwg.org/#shadowroot-clonable'>
6+
<script src='/resources/testharness.js'></script>
7+
<script src='/resources/testharnessreport.js'></script>
8+
9+
<body>
10+
<script>
11+
test(() => {
12+
const div = document.createElement("div");
13+
const root = div.attachShadow({ mode: "open", clonable: true });
14+
root.appendChild(document.createElement("input"));
15+
assert_true(root.clonable, "clonable attribute");
16+
17+
const clone = div.cloneNode(true);
18+
const clonedRoot = clone.shadowRoot;
19+
assert_true(clonedRoot.clonable, "clone gets the same clonable state");
20+
assert_equals(clonedRoot.children.length, 1, "children count");
21+
assert_equals(clonedRoot.children[0].localName, "input", "children content");
22+
}, "attachShadow with clonable: true");
23+
24+
for (const clonable of [false, undefined]) {
25+
test(() => {
26+
const div = document.createElement("div");
27+
const root = div.attachShadow({ mode: "open", clonable });
28+
root.appendChild(document.createElement("input"));
29+
assert_false(root.clonable, "clonable attribute");
30+
31+
const clone = div.cloneNode(true);
32+
assert_true(!clone.shadowRoot, "shadow should not be cloned");
33+
}, `attachShadow with clonable: ${clonable}`);
34+
}
35+
36+
test(() => {
37+
const div = document.createElement("div");
38+
div.setHTMLUnsafe('<div><template shadowrootmode=open><input></template></div>');
39+
const root = div.firstElementChild.shadowRoot;
40+
assert_true(!!root);
41+
assert_true(root.clonable, "clonable is automatically true for declarative shadow root");
42+
43+
const clone = div.cloneNode(true);
44+
const clonedRoot = clone.firstElementChild.shadowRoot;
45+
assert_true(!!clonedRoot);
46+
assert_equals(clonedRoot.children.length, 1, "children count");
47+
assert_equals(clonedRoot.children[0].localName, "input", "children content");
48+
}, "declarative shadow roots get clonable: true automatically");
49+
</script>

0 commit comments

Comments
 (0)