From c4c67222e7b0677f92f43280837db48473603f1e Mon Sep 17 00:00:00 2001
From: Joey Arhar <jarhar@chromium.org>
Date: Wed, 4 Dec 2024 11:40:23 -0800
Subject: [PATCH] Change parser behavior of <select><select>

This patch makes the HTML parser convert nested <select> tags into
</select> instead of </select><select> for backwards compatibility with
the old parser. This behavior will apply to any nested selects, such as
<select><div><select>.

This was recommended here:
https://github.com/whatwg/html/pull/10557#discussion_r1829039074

This will be tested here:
https://github.com/html5lib/html5lib-tests/pull/178#discussion_r1829040445

Change-Id: I7a39901582b96edc10deca8794b9ce117aa08229
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6040687
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1391787}
---
 .../customizable-select/select-parsing.tentative.html  | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/html/semantics/forms/the-select-element/customizable-select/select-parsing.tentative.html b/html/semantics/forms/the-select-element/customizable-select/select-parsing.tentative.html
index d2617a5bec858a..239b54479c3e44 100644
--- a/html/semantics/forms/the-select-element/customizable-select/select-parsing.tentative.html
+++ b/html/semantics/forms/the-select-element/customizable-select/select-parsing.tentative.html
@@ -104,15 +104,15 @@
   const outerSelect = document.getElementById('nested1');
   const innerSelect = document.getElementById('expectafter1');
   const nextDiv = document.getElementById('expectafter1b');
-  assert_true(!!outerSelect && !!innerSelect);
-  assert_equals(outerSelect.nextSibling, innerSelect,'Nested select should be pushed out as the next sibling');
-  assert_equals(innerSelect.nextElementSibling, nextDiv,'Subsequent content is there too');
+  assert_true(!!outerSelect);
+  assert_equals(innerSelect, null,'Nested select should be removed');
+  assert_equals(outerSelect.nextElementSibling, nextDiv,'Subsequent content is there too');
 }, 'Nested selects should be retained 1');
 
 test(() => {
   const outerSelect = document.getElementById('nested2');
   const innerSelect = document.getElementById('expectafter2');
-  assert_true(!!outerSelect && !!innerSelect);
-  assert_equals(outerSelect.nextSibling, innerSelect,'Nested select should be pushed out as the next sibling');
+  assert_true(!!outerSelect);
+  assert_equals(innerSelect, null,'Nested select should be pushed out as the next sibling');
 }, 'Nested selects should be retained 2');
 </script>