From 9d10ab9b7730c365a06fdefc4cdfe51df3be463a Mon Sep 17 00:00:00 2001 From: David Grogan Date: Tue, 19 Feb 2019 19:22:58 -0800 Subject: [PATCH] [css-tables] Add some subpixel collapsed border tests This CL contains tests only, no behavior change. Chrome passes only 001, no matter the device pixels. Safari-lodpi and Firefox-lodpi pass only 001 and 002. EdgeHTML 18.17763-lodpi, Firefox-hidpi, and Safari-hidpi pass 001, 002, and 003. From a plain reading of the tables spec the 003 test is correct. But given its rampant failure (only EdgeHTML passes when 1x device pixel per CSS pixel), it'd be reasonable to codify the current empirical behavior somewhere, if it's not already in a place that I missed. Chrome probably passes 001 but fails 002 because of LayoutUnit's 1/64 pixel precision but that's not confirmed. Note that these tests will become invalid if the proposal in https://github.com/w3c/csswg-drafts/issues/606 is adopted. Bug: 377847 Change-Id: Ifc9e8f9f878f7462cb949670350eadb17c7c2940 Reviewed-on: https://chromium-review.googlesource.com/c/1477334 Reviewed-by: Morten Stenshorne Reviewed-by: David Grogan Commit-Queue: David Grogan Cr-Commit-Position: refs/heads/master@{#633538} --- .../subpixel-collapsed-borders-001.html | 30 +++++++++++++++++++ .../subpixel-collapsed-borders-002.html | 30 +++++++++++++++++++ .../subpixel-collapsed-borders-003-ref.html | 22 ++++++++++++++ .../subpixel-collapsed-borders-003.html | 30 +++++++++++++++++++ .../subpixel-collapsed-borders-ref.html | 22 ++++++++++++++ 5 files changed, 134 insertions(+) create mode 100644 css/css-tables/subpixel-collapsed-borders-001.html create mode 100644 css/css-tables/subpixel-collapsed-borders-002.html create mode 100644 css/css-tables/subpixel-collapsed-borders-003-ref.html create mode 100644 css/css-tables/subpixel-collapsed-borders-003.html create mode 100644 css/css-tables/subpixel-collapsed-borders-ref.html diff --git a/css/css-tables/subpixel-collapsed-borders-001.html b/css/css-tables/subpixel-collapsed-borders-001.html new file mode 100644 index 000000000000000..a71f5cc698b74a5 --- /dev/null +++ b/css/css-tables/subpixel-collapsed-borders-001.html @@ -0,0 +1,30 @@ + + + + + + + + + + + +

There should be a square with a green border, not a red border. +

+ + + + + +
diff --git a/css/css-tables/subpixel-collapsed-borders-002.html b/css/css-tables/subpixel-collapsed-borders-002.html new file mode 100644 index 000000000000000..8f8292cd22becd3 --- /dev/null +++ b/css/css-tables/subpixel-collapsed-borders-002.html @@ -0,0 +1,30 @@ + + + + + + + + + + + +

There should be a square with a green border, not a red border. +

+ + + + + +
diff --git a/css/css-tables/subpixel-collapsed-borders-003-ref.html b/css/css-tables/subpixel-collapsed-borders-003-ref.html new file mode 100644 index 000000000000000..78e0be389393e23 --- /dev/null +++ b/css/css-tables/subpixel-collapsed-borders-003-ref.html @@ -0,0 +1,22 @@ + + + +

There should be a square with a green border, not a red border. +

+ + + + + +
diff --git a/css/css-tables/subpixel-collapsed-borders-003.html b/css/css-tables/subpixel-collapsed-borders-003.html new file mode 100644 index 000000000000000..358562cbd7ff49f --- /dev/null +++ b/css/css-tables/subpixel-collapsed-borders-003.html @@ -0,0 +1,30 @@ + + + + + + + + + + + +

There should be a square with a green border, not a red border. +

+ + + + + +
diff --git a/css/css-tables/subpixel-collapsed-borders-ref.html b/css/css-tables/subpixel-collapsed-borders-ref.html new file mode 100644 index 000000000000000..0a2e7a8d95b95dc --- /dev/null +++ b/css/css-tables/subpixel-collapsed-borders-ref.html @@ -0,0 +1,22 @@ + + + +

There should be a square with a green border, not a red border. +

+ + + + + +