Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subgrid #1

Closed
foolip opened this issue Oct 29, 2021 · 8 comments
Closed

Subgrid #1

foolip opened this issue Oct 29, 2021 · 8 comments
Labels
accepted An accepted proposal focus-area-proposal Focus Area Proposal
Milestone

Comments

@foolip
Copy link
Member

foolip commented Oct 29, 2021

Description
Subgrid makes it possible to nest grids while having the items of the nested grid line up with the main grid. (Simply nesting display: grid doesn't allow this.)

Specification
https://drafts.csswg.org/css-grid-2/

Tests
https://wpt.fyi/results/css/css-grid/subgrid?label=experimental&label=master&aligned

As evident from these tests, only Firefox currently implements Subgrid.

Rationale

(Originally proposed by @scottlow in web-platform-tests/rfcs#99 (comment) before this repo was created.)

@foolip
Copy link
Member Author

foolip commented Nov 4, 2021

Based on the State of CSS 2021 results in #7, I think the case for Subgrid is strong.

@gsnedders
Copy link
Member

Related to #2 would be the question as to whether we treat subgrid as a separate feature to grid generally, or whether we just extend grid to include subgrid.

@foolip
Copy link
Member Author

foolip commented Dec 11, 2021

I have labeled the tests with the interop-2022-subgrid label here:
https://wpt.fyi/results/css/css-grid/subgrid?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&q=label%3Ainterop-2022-subgrid

I excluded two crashtests in the directory, but labeled everything else. If anyone thinks we should include crashtests, please comment.

Is anyone aware of additional test coverage that can/should be added here?

@foolip
Copy link
Member Author

foolip commented Dec 13, 2021

Related to #2 would be the question as to whether we treat subgrid as a separate feature to grid generally, or whether we just extend grid to include subgrid.

I think we should treat it as a separate feature, WDYT?

@karlcow
Copy link

karlcow commented Dec 13, 2021

What would be the pros and cons on both side of the argument?

If as a separate feature it increases the likelihood of being implemented (because not drowned in grid papercuts), probably separate would be better indeed.

Everyone is treating it as a kind of a separate feature.

@foolip
Copy link
Member Author

foolip commented Dec 13, 2021

IMHO, main advantage of separating them is that it's easier to understand and communicate. Subgrid is distinct enough to warrant its own entries on caniuse.com and MDN so we'd be in good company.

The main advantage to merging that I can see is that it sets a precedent for significantly updating the test list of a focus area between two years. We might want to do the same for viewport measurement for 2023, and would have sorted out any issues by then.

@foolip foolip added the accepted An accepted proposal label Dec 14, 2021
This was referenced Dec 16, 2021
@foolip
Copy link
Member Author

foolip commented Jan 10, 2022

A proposed list of tests has been labeled with interop-2022-subgrid. It would be great if someone from each browser engine team can look over this list and comment if there are any issues.

@dlibby-
Copy link

dlibby- commented Jan 15, 2022

That list LGTM, but I suspect we'll be adding more tests as part of implementing subgrid. We should probably come up with a process for adding tests to the list or agree that we will only score against the tests in the initial snapshot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted An accepted proposal focus-area-proposal Focus Area Proposal
Projects
None yet
Development

No branches or pull requests

5 participants