Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ArrayBuffer and DataView to typed-arrays #1668

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

Elchi3
Copy link
Collaborator

@Elchi3 Elchi3 commented Aug 26, 2024

This PR proposes to add 27 BCD keys to the existing typed-array feature. The typed-array feature uses compute_from, so no baseline changes here.

I've used npm run traverse -- -t web-features:typed-arrays to find the exiting typed-array keys and added them to compat_keys. Then I added the following 27 keys to the list:

  • javascript.builtins.ArrayBuffer
  • javascript.builtins.ArrayBuffer.ArrayBuffer
  • javascript.builtins.ArrayBuffer.byteLength
  • javascript.builtins.ArrayBuffer.isView
  • javascript.builtins.ArrayBuffer.slice
  • javascript.builtins.ArrayBuffer.@@species
  • javascript.builtins.DataView
  • javascript.builtins.DataView.DataView
  • javascript.builtins.DataView.buffer
  • javascript.builtins.DataView.byteLength
  • javascript.builtins.DataView.byteOffset
  • javascript.builtins.DataView.getFloat32
  • javascript.builtins.DataView.getFloat64
  • javascript.builtins.DataView.getInt16
  • javascript.builtins.DataView.getInt32
  • javascript.builtins.DataView.getInt8
  • javascript.builtins.DataView.getUint16
  • javascript.builtins.DataView.getUint32
  • javascript.builtins.DataView.getUint8
  • javascript.builtins.DataView.setFloat32
  • javascript.builtins.DataView.setFloat64
  • javascript.builtins.DataView.setInt16
  • javascript.builtins.DataView.setInt32
  • javascript.builtins.DataView.setInt8
  • javascript.builtins.DataView.setUint16
  • javascript.builtins.DataView.setUint32
  • javascript.builtins.DataView.setUint8

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Aug 26, 2024
@jamesnw
Copy link
Collaborator

jamesnw commented Aug 26, 2024

I've used npm run traverse -- -t web-features:typed-arrays to find the exiting typed-array keys and added them to compat_keys. Then I added the following 27 keys to the list:

Thanks for showing the -t flag- I've been manually removing the comments from the .yml.dist file to "un-dist" the tags, and this will be easier! ✨

@Elchi3
Copy link
Collaborator Author

Elchi3 commented Oct 17, 2024

I self-reviewed this against the burndown sheet of non-deprecated and standardized BCD keys and found a few more that have been missed. Now it should be good, though :)

@autonome autonome merged commit 9de9983 into web-platform-dx:main Oct 22, 2024
3 checks passed
@Elchi3 Elchi3 deleted the arraybuffer-dataview branch October 22, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants