Skip to content

chore: only run install case in need #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Timeless0911 merged 1 commit into from
Nov 24, 2023
Merged

chore: only run install case in need #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions scripts/src/pr-bench.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { dev } from './runners/dev';
import { build } from './runners/build';
import {
DefaultBenchCase,
ValidMetricsForCase,
cloneRepo,
getDataPath,
mergeMetrics,
Expand Down Expand Up @@ -29,10 +30,17 @@ async function prBench() {

await build(productName, caseName);

try {
await yarnInstall(productName, caseName);
} catch (err) {
console.log('failed to collect install size metrics:', err);
if (
ValidMetricsForCase[
caseName as keyof typeof ValidMetricsForCase
]?.includes('installSize') ||
!ValidMetricsForCase[caseName as keyof typeof ValidMetricsForCase]
) {
try {
await yarnInstall(productName, caseName);
} catch (err) {
console.log('failed to collect install size metrics:', err);
}
}

await mergeMetrics(productName, caseName);
Expand Down