refactor: remove js stats warning (#10900)

Author: SyMind

crates/node_binding/binding.d.ts

@@ -1291,10 +1291,11 @@ export interface JsStatsCompilation {
   hash?: string
   modules?: Array<JsStatsModule>
   namedChunkGroups?: Array<JsStatsChunkGroup>
-  warnings: Array<JsStatsWarning>
+  warnings: Array<JsStatsError>
 }
 
 export interface JsStatsError {
+  name?: string
   moduleDescriptor?: JsModuleDescriptor
   message: string
   chunkName?: string
@@ -1433,21 +1434,6 @@ export interface JsStatsSize {
   size: number
 }
 
-export interface JsStatsWarning {
-  moduleDescriptor?: JsModuleDescriptor
-  name?: string
-  message: string
-  chunkName?: string
-  code?: string
-  chunkEntry?: boolean
-  chunkInitial?: boolean
-  file?: string
-  chunkId?: string
-  details?: string
-  stack?: string
-  moduleTrace: Array<JsStatsModuleTrace>
-}
-
 export interface JsTap {
   function: any
   stage: number

crates/rspack_binding_api/src/stats.rs

@@ -137,6 +137,7 @@ impl<'a> From<JsModuleDescriptor<'a>> for JsModuleDescriptorWrapper<'a> {
 
 #[napi(object, object_from_js = false)]
 pub struct JsStatsError<'a> {
+  pub name: Option<String>,
   #[napi(ts_type = "JsModuleDescriptor")]
   pub module_descriptor: Option<JsModuleDescriptorWrapper<'a>>,
   pub message: String,
@@ -155,6 +156,7 @@ pub struct JsStatsError<'a> {
 impl<'a> From<rspack_core::StatsError<'a>> for JsStatsError<'a> {
   fn from(stats: rspack_core::StatsError<'a>) -> Self {
     Self {
+      name: stats.name,
       module_descriptor: stats.module_identifier.map(|identifier| {
         JsModuleDescriptor {
           identifier: identifier.into(),
@@ -182,53 +184,6 @@ impl<'a> From<rspack_core::StatsError<'a>> for JsStatsError<'a> {
   }
 }
 
-#[napi(object, object_from_js = false)]
-pub struct JsStatsWarning<'a> {
-  #[napi(ts_type = "JsModuleDescriptor")]
-  pub module_descriptor: Option<JsModuleDescriptorWrapper<'a>>,
-  pub name: Option<String>,
-  pub message: String,
-  pub chunk_name: Option<&'a str>,
-  pub code: Option<String>,
-  pub chunk_entry: Option<bool>,
-  pub chunk_initial: Option<bool>,
-  pub file: Option<&'a str>,
-  pub chunk_id: Option<&'a str>,
-  pub details: Option<String>,
-  pub stack: Option<String>,
-  pub module_trace: Vec<JsStatsModuleTrace<'a>>,
-}
-
-impl<'a> From<rspack_core::StatsWarning<'a>> for JsStatsWarning<'a> {
-  fn from(stats: rspack_core::StatsWarning<'a>) -> Self {
-    Self {
-      module_descriptor: stats.module_identifier.map(|identifier| {
-        JsModuleDescriptor {
-          identifier: identifier.into(),
-          name: CowStrWrapper::new(stats.module_name.unwrap_or_default()),
-          id: stats.module_id.map(|s| to_js_module_id(&s)),
-        }
-        .into()
-      }),
-      name: stats.name,
-      message: stats.message,
-      file: stats.file.map(|f| f.as_str()),
-      code: stats.code,
-      chunk_name: stats.chunk_name,
-      chunk_entry: stats.chunk_entry,
-      chunk_initial: stats.chunk_initial,
-      chunk_id: stats.chunk_id,
-      details: stats.details,
-      stack: stats.stack,
-      module_trace: stats
-        .module_trace
-        .into_iter()
-        .map(Into::into)
-        .collect::<Vec<_>>(),
-    }
-  }
-}
-
 #[napi(object, object_from_js = false)]
 pub struct JsStatsModuleTrace<'a> {
   pub origin: JsStatsModuleTraceModule<'a>,
@@ -1078,7 +1033,7 @@ pub struct JsStatsCompilation<'a> {
   #[napi(ts_type = "Array<JsStatsModule>")]
   pub modules: Option<napi_value>,
   pub named_chunk_groups: Option<Vec<JsStatsChunkGroup<'a>>>,
-  #[napi(ts_type = "Array<JsStatsWarning>")]
+  #[napi(ts_type = "Array<JsStatsError>")]
   pub warnings: napi_value,
 }
 
@@ -1250,7 +1205,7 @@ impl JsStats {
     self.inner.get_warnings(|warnings| {
       let val = warnings
         .into_iter()
-        .map(JsStatsWarning::from)
+        .map(JsStatsError::from)
         .collect::<Vec<_>>();
       unsafe { ToNapiValue::to_napi_value(env.raw(), val) }
     })

crates/rspack_core/src/stats/mod.rs

@@ -649,6 +649,7 @@ impl Stats<'_> {
         );
         let code = d.code().map(|code| code.to_string());
         StatsError {
+          name: d.code().map(|c| c.to_string()),
           message: diagnostic_displayer
             .emit_diagnostic(d)
             .expect("should print diagnostics"),
@@ -676,7 +677,7 @@ impl Stats<'_> {
     f(errors)
   }
 
-  pub fn get_warnings<T>(&self, f: impl Fn(Vec<StatsWarning>) -> T) -> T {
+  pub fn get_warnings<T>(&self, f: impl Fn(Vec<StatsError>) -> T) -> T {
     let mut diagnostic_displayer = DiagnosticDisplayer::new(self.compilation.options.stats.colors);
 
     let module_graph = self.compilation.get_module_graph();
@@ -710,7 +711,7 @@ impl Stats<'_> {
 
         let code = d.code().map(|code| code.to_string());
 
-        StatsWarning {
+        StatsError {
           name: d.code().map(|c| c.to_string()),
           message: diagnostic_displayer
             .emit_diagnostic(d)

crates/rspack_core/src/stats/struct.rs

@@ -39,25 +39,6 @@ pub struct ExtendedStatsOptions {
 
 #[derive(Debug)]
 pub struct StatsError<'a> {
-  pub message: String,
-  pub code: Option<String>,
-  pub module_identifier: Option<ModuleIdentifier>,
-  pub module_name: Option<Cow<'a, str>>,
-  pub module_id: Option<ModuleId>,
-  pub loc: Option<String>,
-  pub file: Option<&'a Utf8Path>,
-
-  pub chunk_name: Option<&'a str>,
-  pub chunk_entry: Option<bool>,
-  pub chunk_initial: Option<bool>,
-  pub chunk_id: Option<&'a str>,
-  pub details: Option<String>,
-  pub stack: Option<String>,
-  pub module_trace: Vec<StatsModuleTrace<'a>>,
-}
-
-#[derive(Debug)]
-pub struct StatsWarning<'a> {
   pub name: Option<String>,
   pub message: String,
   pub code: Option<String>,

packages/rspack-test-tools/tests/__snapshots__/StatsOutput.test.js.snap

@@ -470,7 +470,7 @@ Rspack compiled successfully
 `;
 
 exports[`statsOutput statsOutput/try-require-module should print correct stats for 1`] = `
-WARNING in ./index.js
+WARNING in ./index.js 2:12-31
   ⚠ Module not found: Can't resolve './missing-module' in '<TEST_TOOLS_ROOT>/tests/statsOutputCases/try-require-module'
    ╭─[2:4]
  1 │ try {

packages/rspack-test-tools/tests/diagnosticsCases/factorize/missing-module/raw-warning.err

@@ -1,5 +1,6 @@
 Array [
   Object {
+    loc: 4:16-35,
     moduleIdentifier: <TEST_TOOLS_ROOT>/tests/diagnosticsCases/factorize/missing-module/index.js,
     moduleName: ./index.js,
   },

packages/rspack-test-tools/tests/diagnosticsCases/factorize/missing-module/stats.err

@@ -1,4 +1,4 @@
-WARNING in ./index.js
+WARNING in ./index.js 4:16-35
   ⚠ Module not found: Can't resolve './missing-module' in '<TEST_TOOLS_ROOT>/tests/diagnosticsCases/factorize/missing-module'
    ╭─[4:8]
  2 │     let errored = false;

packages/rspack/etc/core.api.md

@@ -59,7 +59,6 @@ import type { JsRuntimeModule } from '@rspack/binding';
 import type { JsStats } from '@rspack/binding';
 import type { JsStatsCompilation } from '@rspack/binding';
 import type { JsStatsError } from '@rspack/binding';
-import type { JsStatsWarning } from '@rspack/binding';
 import * as liteTapable from '@rspack/lite-tapable';
 import { Logger } from './logging/Logger';
 import { Module } from '@rspack/binding';
@@ -3923,7 +3922,7 @@ type KnownStatsFactoryContext = {
     makePathsRelative?: ((arg0: string) => string) | undefined;
     compilation?: Compilation | undefined;
     cachedGetErrors?: ((arg0: Compilation) => JsStatsError[]) | undefined;
-    cachedGetWarnings?: ((arg0: Compilation) => JsStatsWarning[]) | undefined;
+    cachedGetWarnings?: ((arg0: Compilation) => JsStatsError[]) | undefined;
     getStatsCompilation: (compilation: Compilation) => JsStatsCompilation;
     getInner: (compilation: Compilation) => JsStats;
 };

packages/rspack/src/stats/DefaultStatsFactoryPlugin.ts

@@ -13,8 +13,7 @@ import type {
 	JsOriginRecord,
 	JsStatsAssetInfo,
 	JsStatsError,
-	JsStatsModule,
-	JsStatsWarning
+	JsStatsModule
 } from "@rspack/binding";
 import type { Chunk } from "../Chunk";
 import type { NormalizedStatsOptions } from "../Compilation";
@@ -609,7 +608,7 @@ const EXTRACT_ERROR: Record<
 	string,
 	(
 		object: StatsError,
-		error: JsStatsError | JsStatsWarning,
+		error: JsStatsError,
 		context: KnownStatsFactoryContext,
 		options: StatsOptions,
 		factory: StatsFactory

packages/rspack/src/stats/StatsFactory.ts

@@ -10,8 +10,7 @@
 import type {
 	JsStats,
 	JsStatsCompilation,
-	JsStatsError,
-	JsStatsWarning
+	JsStatsError
 } from "@rspack/binding";
 import { HookMap, SyncBailHook, SyncWaterfallHook } from "@rspack/lite-tapable";
 
@@ -28,7 +27,7 @@ export type KnownStatsFactoryContext = {
 	// compilationAuxiliaryFileToChunks?: Map<string, Chunk[]> | undefined;
 	// runtime?: RuntimeSpec | undefined;
 	cachedGetErrors?: ((arg0: Compilation) => JsStatsError[]) | undefined;
-	cachedGetWarnings?: ((arg0: Compilation) => JsStatsWarning[]) | undefined;
+	cachedGetWarnings?: ((arg0: Compilation) => JsStatsError[]) | undefined;
 	getStatsCompilation: (compilation: Compilation) => JsStatsCompilation;
 	getInner: (compilation: Compilation) => JsStats;
 };