fix: preserve star export from external module (#8217)

* fix: preserve star export from external module

* replace dep in modern-module

Author: fi3ework

crates/rspack_core/src/compiler/make/cutout/has_module_graph_change.rs

@@ -232,6 +232,10 @@ mod t {
       self.deps.push(dependency);
     }
 
+    fn remove_dependency_id(&mut self, dependency: DependencyId) {
+      self.deps.retain(|dep| dep != &dependency);
+    }
+
     fn get_dependencies(&self) -> &[DependencyId] {
       &self.deps
     }

crates/rspack_core/src/concatenated_module.rs

@@ -450,6 +450,10 @@ impl DependenciesBlock for ConcatenatedModule {
     self.dependencies.push(dependency)
   }
 
+  fn remove_dependency_id(&mut self, dependency: DependencyId) {
+    self.dependencies.retain(|d| d != &dependency)
+  }
+
   fn get_dependencies(&self) -> &[DependencyId] {
     &self.dependencies
   }

crates/rspack_core/src/context_module.rs

@@ -817,6 +817,10 @@ impl DependenciesBlock for ContextModule {
     self.dependencies.push(dependency)
   }
 
+  fn remove_dependency_id(&mut self, dependency: DependencyId) {
+    self.dependencies.retain(|d| d != &dependency)
+  }
+
   fn get_dependencies(&self) -> &[DependencyId] {
     &self.dependencies
   }

crates/rspack_core/src/dependencies_block.rs

@@ -19,6 +19,8 @@ pub trait DependenciesBlock {
 
   fn add_dependency_id(&mut self, dependency: DependencyId);
 
+  fn remove_dependency_id(&mut self, _dependency: DependencyId);
+
   fn get_dependencies(&self) -> &[DependencyId];
 }
 
@@ -194,14 +196,12 @@ impl DependenciesBlock for AsyncDependenciesBlock {
     self.dependency_ids.push(dependency)
   }
 
-  fn get_dependencies(&self) -> &[DependencyId] {
-    &self.dependency_ids
+  fn remove_dependency_id(&mut self, dependency: DependencyId) {
+    self.dependency_ids.retain(|dep| dep != &dependency);
   }
-}
 
-impl AsyncDependenciesBlock {
-  pub fn remove_dependency_id(&mut self, dependency: DependencyId) {
-    self.dependency_ids.retain(|dep| dep != &dependency);
+  fn get_dependencies(&self) -> &[DependencyId] {
+    &self.dependency_ids
   }
 }
 

crates/rspack_core/src/external_module.rs

@@ -398,6 +398,10 @@ impl DependenciesBlock for ExternalModule {
     self.dependencies.push(dependency)
   }
 
+  fn remove_dependency_id(&mut self, dependency: DependencyId) {
+    self.dependencies.retain(|d| d != &dependency)
+  }
+
   fn get_dependencies(&self) -> &[DependencyId] {
     &self.dependencies
   }

crates/rspack_core/src/module.rs

@@ -646,6 +646,10 @@ mod test {
           unreachable!()
         }
 
+        fn remove_dependency_id(&mut self, _: DependencyId) {
+          unreachable!()
+        }
+
         fn get_dependencies(&self) -> &[DependencyId] {
           unreachable!()
         }

crates/rspack_core/src/normal_module.rs

@@ -339,6 +339,10 @@ impl DependenciesBlock for NormalModule {
     self.dependencies.push(dependency)
   }
 
+  fn remove_dependency_id(&mut self, dependency: DependencyId) {
+    self.dependencies.retain(|d| d != &dependency)
+  }
+
   fn get_dependencies(&self) -> &[DependencyId] {
     &self.dependencies
   }

crates/rspack_core/src/raw_module.rs

@@ -71,6 +71,10 @@ impl DependenciesBlock for RawModule {
     self.dependencies.push(dependency)
   }
 
+  fn remove_dependency_id(&mut self, dependency: DependencyId) {
+    self.dependencies.retain(|d| d != &dependency)
+  }
+
   fn get_dependencies(&self) -> &[DependencyId] {
     &self.dependencies
   }

crates/rspack_core/src/self_module.rs

@@ -61,6 +61,10 @@ impl DependenciesBlock for SelfModule {
     self.dependencies.push(dependency)
   }
 
+  fn remove_dependency_id(&mut self, dependency: DependencyId) {
+    self.dependencies.retain(|d| d != &dependency)
+  }
+
   fn get_dependencies(&self) -> &[DependencyId] {
     &self.dependencies
   }

crates/rspack_macros/src/runtime_module.rs

@@ -100,6 +100,10 @@ pub fn impl_runtime_module(
         unreachable!()
       }
 
+      fn remove_dependency_id(&mut self, _: ::rspack_core::DependencyId) {
+        unreachable!()
+      }
+
       fn get_dependencies(&self) -> &[::rspack_core::DependencyId] {
         unreachable!()
       }