refactor: use atomic_refcell for async_module_artifact (#12408)

refacto: use atomic_refcell for async_module_artifact

Author: hardfist

Cargo.lock

@@ -258,7 +258,7 @@ impl JsModuleGraph {
   pub fn is_async(&self, module: ModuleObjectRef) -> napi::Result<bool> {
     let (compilation, _) = self.as_ref()?;
     Ok(ModuleGraph::is_async(
-      &compilation.async_modules_artifact,
+      &compilation.async_modules_artifact.borrow(),
       &module.identifier,
     ))
   }

crates/rspack_binding_api/src/module_graph.rs

@@ -10,6 +10,7 @@ version.workspace = true
 anymap = { workspace = true }
 async-recursion = { workspace = true }
 async-trait = { workspace = true }
+atomic_refcell = { workspace = true }
 bitflags = { workspace = true }
 cow-utils = { workspace = true }
 dashmap = { workspace = true, features = ["rayon"] }

crates/rspack_core/Cargo.toml

@@ -383,8 +383,11 @@ impl ChunkGraph {
           .hash(&mut hasher);
         module.source_types(&mg).dyn_hash(&mut hasher);
 
-        ModuleGraph::is_async(&compilation.async_modules_artifact, &module_identifier)
-          .dyn_hash(&mut hasher);
+        ModuleGraph::is_async(
+          &compilation.async_modules_artifact.borrow(),
+          &module_identifier,
+        )
+        .dyn_hash(&mut hasher);
         let exports_info =
           mg.get_prefetched_exports_info(&module_identifier, PrefetchExportsInfoMode::Full);
         let (entry, exports) = exports_info.meta();

crates/rspack_core/src/chunk_graph/chunk_graph_module.rs

@@ -11,6 +11,7 @@ use std::{
   },
 };
 
+use atomic_refcell::AtomicRefCell;
 use build_chunk_graph::{
   artifact::use_code_splitting_cache, build_chunk_graph, build_chunk_graph_new,
 };
@@ -247,7 +248,7 @@ pub struct Compilation {
   pub runtime_template: RuntimeTemplate,
 
   // artifact for infer_async_modules_plugin
-  pub async_modules_artifact: DerefOption<AsyncModulesArtifact>,
+  pub async_modules_artifact: Arc<AtomicRefCell<AsyncModulesArtifact>>,
   // artifact for collect_dependencies_diagnostics
   pub dependencies_diagnostics_artifact: DerefOption<DependenciesDiagnosticsArtifact>,
   // artifact for side_effects_flag_plugin
@@ -386,7 +387,7 @@ impl Compilation {
       named_chunks: Default::default(),
       named_chunk_groups: Default::default(),
 
-      async_modules_artifact: DerefOption::new(AsyncModulesArtifact::default()),
+      async_modules_artifact: Arc::new(AtomicRefCell::new(AsyncModulesArtifact::default())),
       imported_by_defer_modules_artifact: Default::default(),
       dependencies_diagnostics_artifact: DerefOption::new(
         DependenciesDiagnosticsArtifact::default(),

crates/rspack_core/src/compilation/mod.rs

@@ -325,17 +325,16 @@ impl Compiler {
     self.build_module_graph().await?;
     let mut dependencies_diagnostics_artifact =
       mem::take(&mut self.compilation.dependencies_diagnostics_artifact);
-    let mut async_modules_artifact = mem::take(&mut self.compilation.async_modules_artifact);
+    let async_modules_artifact = self.compilation.async_modules_artifact.clone();
     let diagnostics = self
       .compilation
       .collect_build_module_graph_effects(
         &mut dependencies_diagnostics_artifact,
-        &mut async_modules_artifact,
+        &mut async_modules_artifact.borrow_mut(),
       )
       .await?;
     self.compilation.extend_diagnostics(diagnostics);
     self.compilation.dependencies_diagnostics_artifact = dependencies_diagnostics_artifact;
-    self.compilation.async_modules_artifact = async_modules_artifact;
     self.compilation.seal(self.plugin_driver.clone()).await?;
     logger.time_end(start);
 

crates/rspack_core/src/compiler/mod.rs

@@ -1,6 +1,5 @@
 use std::{
   collections::hash_map::Entry,
-  mem,
   ops::{Deref, DerefMut},
 };
 
@@ -445,10 +444,10 @@ impl<'a> ModuleGraph<'a> {
     new_mgm.depth = assign_tuple.2;
     new_mgm.exports = assign_tuple.3;
 
-    let is_async = ModuleGraph::is_async(&compilation.async_modules_artifact, source_module);
-    let mut async_modules_artifact = mem::take(&mut compilation.async_modules_artifact);
+    let is_async =
+      ModuleGraph::is_async(&compilation.async_modules_artifact.borrow(), source_module);
+    let mut async_modules_artifact = compilation.async_modules_artifact.borrow_mut();
     ModuleGraph::set_async(&mut async_modules_artifact, *target_module, is_async);
-    compilation.async_modules_artifact = async_modules_artifact;
   }
 
   pub fn move_module_connections(

crates/rspack_core/src/module_graph/mod.rs

@@ -930,7 +930,7 @@ impl RuntimeTemplate {
         }
         runtime_requirements.insert(RuntimeGlobals::CREATE_FAKE_NAMESPACE_OBJECT);
         if ModuleGraph::is_async(
-          &compilation.async_modules_artifact,
+          &compilation.async_modules_artifact.borrow(),
           compilation
             .get_module_graph()
             .module_identifier_by_dependency_id(dep_id)
@@ -1356,7 +1356,10 @@ fn get_outgoing_async_modules(
     visited: &mut HashSet<ModuleIdentifier>,
   ) {
     let module_identifier = module.identifier();
-    if !ModuleGraph::is_async(&compilation.async_modules_artifact, &module_identifier) {
+    if !ModuleGraph::is_async(
+      &compilation.async_modules_artifact.borrow(),
+      &module_identifier,
+    ) {
       return;
     }
     if !visited.insert(module_identifier) {

crates/rspack_core/src/runtime_template.rs

@@ -184,7 +184,8 @@ impl ExternalInterop {
     let mut source = ConcatSource::default();
     let name = self.required_symbol.as_ref();
 
-    let is_async = ModuleGraph::is_async(&compilation.async_modules_artifact, &self.module);
+    let is_async =
+      ModuleGraph::is_async(&compilation.async_modules_artifact.borrow(), &self.module);
 
     if let Some(name) = name {
       source.add(RawStringSource::from(format!(

crates/rspack_plugin_esm_library/src/chunk_link.rs

@@ -68,7 +68,7 @@ fn then_expr(
       }
       runtime_requirements.insert(RuntimeGlobals::CREATE_FAKE_NAMESPACE_OBJECT);
       if ModuleGraph::is_async(
-        &compilation.async_modules_artifact,
+        &compilation.async_modules_artifact.borrow(),
         compilation
           .get_module_graph()
           .module_identifier_by_dependency_id(dep_id)