refactor: to_string when nessarry

Author: stormslowly

src/lib.rs

@@ -1760,8 +1760,7 @@ impl<Fs: FileSystem + Send + Sync> ResolverGeneric<Fs> {
     let mut best_key = String::new();
     // 2. Let expansionKeys be the list of keys of matchObj containing only a single "*", sorted by the sorting function PATTERN_KEY_COMPARE which orders in descending order of specificity.
     // 3. For each key expansionKey in expansionKeys, do
-    for (key, target) in match_obj {
-      let expansion_key = key.to_string();
+    for (expansion_key, target) in match_obj {
       if expansion_key.starts_with("./") || expansion_key.starts_with('#') {
         // 1. Let patternBase be the substring of expansionKey up to but excluding the first "*" character.
         if let Some((pattern_base, pattern_trailer)) = expansion_key.split_once('*') {
@@ -1779,16 +1778,16 @@ impl<Fs: FileSystem + Send + Sync> ResolverGeneric<Fs> {
             best_target = Some(target);
             // 2. Let patternMatch be the substring of matchKey starting at the index of the length of patternBase up to the length of matchKey minus the length of patternTrailer.
             best_match = &match_key[pattern_base.len()..match_key.len() - pattern_trailer.len()];
-            best_key = expansion_key;
+            best_key = expansion_key.to_string();
           }
         } else if expansion_key.ends_with('/')
-          && match_key.starts_with(&expansion_key)
-          && Self::pattern_key_compare(&best_key, &expansion_key).is_gt()
+          && match_key.starts_with(&**expansion_key)
+          && Self::pattern_key_compare(&best_key, expansion_key).is_gt()
         {
           // TODO: [DEP0148] DeprecationWarning: Use of deprecated folder mapping "./dist/" in the "exports" field module resolution of the package at xxx/package.json.
           best_target = Some(target);
           best_match = &match_key[expansion_key.len()..];
-          best_key.clone_from(&expansion_key);
+          best_key = expansion_key.to_string();
         }
       }
     }