Skip to content

Commit 5cab967

Browse files
committed
chore: remove validation code in benches
1 parent 82071e5 commit 5cab967

File tree

1 file changed

+1
-15
lines changed

1 file changed

+1
-15
lines changed

benches/resolver.rs

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -148,22 +148,10 @@ fn create_async_resolve_task(
148148
fn bench_resolver(c: &mut Criterion) {
149149
let data = data();
150150

151-
// check validity
152-
// for (path, request) in &data {
153-
// assert!(oxc_resolver().resolve(path, request).is_ok(), "{path:?} {request}");
154-
// }
155-
156151
let symlink_test_dir = create_symlinks().expect("Create symlink fixtures failed");
157152

158153
let symlinks_range = 0u32..10000;
159154

160-
// for i in symlinks_range.clone() {
161-
// assert!(
162-
// oxc_resolver().resolve(&symlink_test_dir, &format!("./file{i}")).is_ok(),
163-
// "file{i}.js"
164-
// );
165-
// }
166-
167155
let mut group = c.benchmark_group("resolver");
168156

169157
group.bench_with_input(BenchmarkId::from_parameter("single-thread"), &data, |b, data| {
@@ -195,9 +183,7 @@ fn bench_resolver(c: &mut Criterion) {
195183
BenchmarkId::from_parameter("resolve-from-symlinks"),
196184
&symlinks_range,
197185
|b, data| {
198-
let runner = runtime::Builder::new_current_thread()
199-
.build()
200-
.expect("failed to create tokio runtime");
186+
let runner = runtime::Runtime::new().expect("failed to create tokio runtime");
201187
b.to_async(runner).iter(|| async {
202188
let oxc_resolver = oxc_resolver();
203189
for i in data.clone() {

0 commit comments

Comments
 (0)