Previous fix for eddsa key fail at authentication

[Gashmob]

Version(s) affected

4.6.4

Description

Your previous fix for registration of eddsa key works fine (#436). But I've not tried if it works for authentication before today.

When you fix the cbor map in load you define a field as a byte string: AuthenticatorDataLoader.php line 110

->add(UnsignedIntegerObject::create(1), ByteStringObject::create('OKP'))

Or in https://www.rfc-editor.org/rfc/rfc8152#section-7 it tell that it must be a text string or an integer

How to reproduce

Use a recent yubikey (eg. firmware 5.4.3), register it with eddsa as prefered algorithm, then use it for authentication.

Possible Solution

- ->add(UnsignedIntegerObject::create(1), ByteStringObject::create('OKP'))
+ ->add(UnsignedIntegerObject::create(1), TextStringObject::create('OKP'))

I can create the pr if you want as the fix is very small

Additional Context

No response

[Gashmob]

In parallel, in class OkpKey, when you check fields 1 and -1, you assume that the value is an int, but it can also be a text string. And same in class EdDSA, when you check again field -1.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.