Change onSample to onsample as discussed with Shane, Brian.

Author: rjwright

src/effect-callback.js

@@ -23,7 +23,7 @@
     if (isKeyframeEffect) {
       effectFunction = animation.effect.getFrames();
     } else {
-      effectFunction = animation.effect._onSample;
+      effectFunction = animation.effect._onsample;
     }
     var timing = animation.effect.timing;
     var last = null;

src/group-constructors.js

@@ -180,7 +180,7 @@
     };
 
     var underlyingEffect = new KeyframeEffect(null, [], group._timing);
-    underlyingEffect.onSample = ticker;
+    underlyingEffect.onsample = ticker;
     underlyingAnimation = scope.timeline._play(underlyingEffect);
     return underlyingAnimation;
   };

src/keyframe-effect-constructor.js

@@ -61,7 +61,7 @@
 
     this.timing = shared.makeTiming(timingInput);
     if (typeof effectInput == 'function') {
-      shared.deprecated('Custom KeyframeEffect', '2015-06-22', 'Use KeyframeEffect.onSample instead.');
+      shared.deprecated('Custom KeyframeEffect', '2015-06-22', 'Use KeyframeEffect.onsample instead.');
       this._normalizedKeyframes = effectInput;
     } else {
       this._normalizedKeyframes = new KeyframeList(effectInput);
@@ -81,11 +81,11 @@
       shared.deprecated('KeyframeEffect.effect', '2015-03-23', 'Use KeyframeEffect.getFrames() instead.');
       return this._normalizedKeyframes;
     },
-    set onSample(callback) {
+    set onsample(callback) {
       if (typeof this.getFrames() == 'function') {
-        throw new Error('Setting onSample on custom effect KeyframeEffect is not supported.');
+        throw new Error('Setting onsample on custom effect KeyframeEffect is not supported.');
       }
-      this._onSample = callback;
+      this._onsample = callback;
       if (this._animation) {
         this._animation._rebuildUnderlyingAnimation();
       }

src/web-animations-next-animation.js

@@ -86,7 +86,7 @@
         this._animation = scope.newUnderlyingAnimationForGroup(this.effect);
         scope.bindAnimationForGroup(this);
       }
-      if (this.effect && this.effect._onSample) {
+      if (this.effect && this.effect._onsample) {
         scope.bindAnimationForCustomEffect(this);
       }
       if (hadUnderlying) {

test/js/effect-callback.js

@@ -8,7 +8,7 @@ suite('effect-callback', function() {
     var fractions = [];
     tick(100);
     var effect = new KeyframeEffect(null, [], 1000);
-    effect.onSample = function(fraction) {
+    effect.onsample = function(fraction) {
       fractions.push(fraction);
     };
     var animation = document.timeline.play(effect);
@@ -23,7 +23,7 @@ suite('effect-callback', function() {
     var timeFraction;
     tick(0);
     var effect = new KeyframeEffect(null, [], {duration: 0, fill: 'both'});
-    effect.onSample = function(t) {
+    effect.onsample = function(t) {
       timeFraction = t;
     };
     var animation = document.timeline.play(effect);
@@ -38,10 +38,10 @@ suite('effect-callback', function() {
     tick(0);
     var effect = new KeyframeEffect(null, [], 2);
     var effect2 = new KeyframeEffect(null, [], 1);
-    effect.onSample = function() {
+    effect.onsample = function() {
       animation = document.timeline.play(effect2);
     };
-    effect2.onSample = function() {
+    effect2.onsample = function() {
       called = true;
     };
     document.timeline.play(effect);
@@ -53,7 +53,7 @@ suite('effect-callback', function() {
   test('custom effect should be called after cancel', function() {
     var fractions = [];
     var effect = new KeyframeEffect(null, [], 1000);
-    effect.onSample = function(fraction) {
+    effect.onsample = function(fraction) {
       fractions.push(fraction);
     };
     var animation = document.timeline.play(effect);
@@ -68,7 +68,7 @@ suite('effect-callback', function() {
     var callbackEffect;
     var callbackAnim;
     var effect = new KeyframeEffect(document.body, [], 100);
-    effect.onSample = function(t, e, a) {
+    effect.onsample = function(t, e, a) {
       callbackEffect = e;
       callbackAnim = a;
     };