Make event handling asynchronous #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The testharness can't handle two levels of asynchronousicity unfortunately so the test for this bug has to be manual. |
| var element = document.querySelector('#target'); | ||
| var animation = new Animation(element, { left: '50px' }, 0.5); | ||
| animation.addEventListener('end', function() { | ||
| console.log('testpants'); |
There was a problem hiding this comment.
Should this be 'testPants' for consistency?
There was a problem hiding this comment.
On second thoughts best not to have logging at all ;)
There was a problem hiding this comment.
The non-camel cased debug print comes back to haunt me!
Yes it should be testPants and yes it should not be there. :)
dstoc
added a commit
that referenced
this pull request
Aug 20, 2013
Make event handling asynchronous
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When players are played in the end event of the last player they do not get played.
Making the events fire asynchronously fixes the problem by allowing player registration to occur at the appropriate time.